Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lockscreen has the wrong layout if you lock the app with the keybord open. #2032

Closed
ara4n opened this issue Nov 5, 2023 · 1 comment · Fixed by #2034
Closed

Lockscreen has the wrong layout if you lock the app with the keybord open. #2032

ara4n opened this issue Nov 5, 2023 · 1 comment · Fixed by #2034
Labels
A-App-Lock O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Nov 5, 2023 •
edited
Loading

Steps to reproduce

  1. Enable PIN
  2. Open a timeline (thus displaying the keyboard)
  3. Lock the app by bging it
  4. Fg it
  5. Observe that the animation of app launch blends between a correct(?) lock screen graphic (with the centered Element X logo) and an incorrect(?) one (with the logo offset by the height of the keyboard). As a result you see doubled up logos during the launch animation, which looks really unpolished and wrecks what would otherwise be a really nice visual polish.

IMG_3913

  1. Compare it when you do the same operation with the keyboard shut (eg by bging in the unfiltered roomlist), and see how nice it looks without the bug (ignoring the FaceID overlay):

IMG_3915

Outcome

What did you expect?

pretty lock screen

What happened instead?

IMG_3916

Your phone model

iphone 12 pro max

Operating system version

16.4

Application version

428

Homeserver

No response

Will you send logs?

No
@Velin92 Velin92 added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-App-Lock T-Defect labels Nov 6, 2023
@pixlwave pixlwave mentioned this issue Nov 6, 2023
Merged
@pixlwave pixlwave mentioned this issue Nov 8, 2023
Merged
@ara4n
Copy link
Member Author

ara4n commented Nov 8, 2023

confirmed fixed; huge polish improvement - thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-App-Lock O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't allow the Placeholder Screen layout to be influenced by the keyboard element-hq/element-x-ios
2 participants
@ara4n @Velin92