Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits sometimes show original msg, not edited msg. #2252

Closed
ara4n opened this issue Dec 15, 2023 · 10 comments
Closed

Edits sometimes show original msg, not edited msg. #2252

ara4n opened this issue Dec 15, 2023 · 10 comments
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@ara4n
Copy link
Member

ara4n commented Dec 15, 2023

Steps to reproduce

  1. Send a message on another client (EW in this case)
  2. Someone reacts to it (this may or may not be important)
  3. Edit your msg
  4. More reactions happen

Later, view the msg in scrollback on EX. It’s shown as edited, but the contents shows the pre-edited contents, not the edited content! 🙀

concretely:

image

is a msg i sent, and then fixed the thinko of “go” to “typescript”. but the edit doesn’t show up.

Outcome

What did you expect?

reliable edits

What happened instead?

flakey timeline code.

Your phone model

No response

Operating system version

No response

Application version

463

Homeserver

No response

Will you send logs?

Yes

@ara4n
Copy link
Member Author

ara4n commented Dec 15, 2023

rageshake is down so i can't submit logs. https://matrix.to/#/!IIDRCwzJTNnOmMxacp%3Amatrix.org/%24BkoaVoIn-FFKS64JNoVQUiJuF7e_IG0J1wB-Z41A7BQ is the msg in q

@ara4n ara4n added the T-Defect label Dec 17, 2023
@Velin92 Velin92 added X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely labels Dec 19, 2023
@ara4n
Copy link
Member Author

ara4n commented Dec 27, 2023

it often seems to flip back and forth - i just saw it flap between the edited and non edited version in the timeline about 3 times after having sent the edit...

@ara4n
Copy link
Member Author

ara4n commented Jan 20, 2024

see also #1895

@stefanceriu
Copy link
Member

stefanceriu commented Jun 21, 2024

Still 100% reproducible (reactions don't matter). They fix themselves after re-entering the room after having loaded them once and then break again when clearing out the cache.

@stefanceriu
Copy link
Member

Already reported on the RustSDK under matrix-org/matrix-rust-sdk#3492

@manuroe
Copy link
Member

manuroe commented Jun 21, 2024

@Hywan could this be fixed by the event cache storage?

@manuroe
Copy link
Member

manuroe commented Jul 11, 2024

@Hywan could this be fixed by the event cache storage?

it is not.

@ara4n
Copy link
Member Author

ara4n commented Aug 27, 2024

still getting it on build 690

@bnjbvr
Copy link
Member

bnjbvr commented Oct 10, 2024

I've closed the SDK issue, because lots of engineering work has been spent on this, and most issues should now be fixed. As explained there, please open new issues if that happens again, with precise STRs; the symptom (missing edit) can be caused by many causes; for instance, there are some rageshakes here that relate to local echoes for edits, unrelated to the original issue filed here. Thanks!

@bnjbvr bnjbvr removed their assignment Oct 10, 2024
@manuroe
Copy link
Member

manuroe commented Oct 10, 2024

thanks @bnjbvr for all the fixes. Let's close this issue and create more accurate ones if needed.

@manuroe manuroe closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
Development

No branches or pull requests

5 participants