-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edits sometimes show original msg, not edited msg. #2252
Comments
rageshake is down so i can't submit logs. https://matrix.to/#/!IIDRCwzJTNnOmMxacp%3Amatrix.org/%24BkoaVoIn-FFKS64JNoVQUiJuF7e_IG0J1wB-Z41A7BQ is the msg in q |
it often seems to flip back and forth - i just saw it flap between the edited and non edited version in the timeline about 3 times after having sent the edit... |
see also #1895 |
Still 100% reproducible (reactions don't matter). They fix themselves after re-entering the room after having loaded them once and then break again when clearing out the cache. |
Already reported on the RustSDK under matrix-org/matrix-rust-sdk#3492 |
@Hywan could this be fixed by the event cache storage? |
it is not. |
still getting it on build 690 |
I've closed the SDK issue, because lots of engineering work has been spent on this, and most issues should now be fixed. As explained there, please open new issues if that happens again, with precise STRs; the symptom (missing edit) can be caused by many causes; for instance, there are some rageshakes here that relate to local echoes for edits, unrelated to the original issue filed here. Thanks! |
thanks @bnjbvr for all the fixes. Let's close this issue and create more accurate ones if needed. |
Steps to reproduce
Later, view the msg in scrollback on EX. It’s shown as edited, but the contents shows the pre-edited contents, not the edited content! 🙀
concretely:
is a msg i sent, and then fixed the thinko of “go” to “typescript”. but the edit doesn’t show up.
Outcome
What did you expect?
reliable edits
What happened instead?
flakey timeline code.
Your phone model
No response
Operating system version
No response
Application version
463
Homeserver
No response
Will you send logs?
Yes
The text was updated successfully, but these errors were encountered: