Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when pasting XML into the RTE #2265

Closed
ara4n opened this issue Dec 18, 2023 · 3 comments · Fixed by #2327
Closed

Crash when pasting XML into the RTE #2265

ara4n opened this issue Dec 18, 2023 · 3 comments · Fixed by #2327
Assignees
@Velin92
Labels
A-Rich-Text-Editor A-Send event A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround

Comments

@ara4n
Copy link
Member

ara4n commented Dec 18, 2023

Steps to reproduce

  1. Was running EXI on macOS
  2. RTE disabled
  3. Paste XML (see rageshake)
  4. App crashes

Outcome

What did you expect?

no crash

What happened instead?

big badda boom

Your phone model

No response

Operating system version

No response

Application version

465

Homeserver

No response

Will you send logs?

Yes
@stefanceriu
Copy link
Member

This is trivial to reproduce with the XML from the rageshake and is a problem on iOS too. The RTE reports its content as empty on sending and the app fatalErrors here (which is correct)

I tracked it down to this plainTextMode check on the RTE side but I'm not sure what it means https://github.com/matrix-org/matrix-rich-text-editor/blob/main/platforms/ios/lib/WysiwygComposer/Sources/WysiwygComposer/Components/WysiwygComposerView/WysiwygComposerViewModel.swift#L113

Can you please have a look @Velin92 ?

@stefanceriu stefanceriu added A-Timeline A-Send event S-Critical Prevents work, causes data loss and/or has no workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Rich-Text-Editor labels Dec 19, 2023
@Velin92 Velin92 added O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Dec 19, 2023
@Velin92 Velin92 mentioned this issue Dec 19, 2023
Open
@Velin92
Copy link
Member

Velin92 commented Dec 19, 2023

matrix-org/matrix-rich-text-editor#910 this is a rust side issue of the markdown content parsing opened up an issue for it

@Velin92 Velin92 mentioned this issue Jan 12, 2024
Merged
@Velin92
Copy link
Member

Velin92 commented Jan 12, 2024

This will be fixed by #2327
However this will just prevent the crash from happening, the markdown mode still may interpret the xml or the html wrong (removing some of the tags for example) if they are not inserted in a codeblock or similiar, but that is probably to be expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Velin92 Velin92

Labels
A-Rich-Text-Editor A-Send event A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reverting RTE to use SDK markdown when in markdown mode element-hq/element-x-ios
3 participants
@stefanceriu @ara4n @Velin92