generated from element-hq/.github
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce more flow coordinators #919
Labels
Comments
Merged
stefanceriu
added a commit
that referenced
this issue
May 26, 2023
…d FlowCoordinator protocol Squashed commits: Add unit tests and move the state machine into the FlowCoordinator [bb68686] Replace the RoomFlowCoordinator's public interface with just `handleAppRoute` [0d9a4f8] Remove the navigationStackCoordinator dependency from the roomScreenCoordinator [4b5fbdf] Allow rooms to be selected from any other state [41dbd12] Move all missing coordinators to the RoomFlowCoordinator and state machines [f32431b] The UserSessionFlowCoordinator does not need to conform to the CoordinatorProtocol [0f07e87] Fix leaving a room dismissing the currently selected one when different [138385a] Rewind the navigation stack when re-selecting the same room (iPad) [0727eb9] Fix presenting different room details from the side menu on iPads [faf4cc6] Fix selecting the same room multiple times [fb3391d] Move room details presentation responsibility to the RoomFlowCoordinator. Fixed invitation flows. [fa2a68d] Rename RoomTimelineFlowCoordinator -> RoomFlowCoordinator [0c9c06b] Start moving things away from the RoomScreenCoordinator and into the RoomTimelineFlowCoordinator [86cbbdc] Introduce a RoomTimelineFlowCoordinator to deal with timeline related operations [9b2381b] Introduce the FlowCoordinatorProtocol
stefanceriu
added a commit
that referenced
this issue
May 26, 2023
…d FlowCoordinator protocol Squashed commits: Add unit tests and move the state machine into the FlowCoordinator [bb68686] Replace the RoomFlowCoordinator's public interface with just `handleAppRoute` [0d9a4f8] Remove the navigationStackCoordinator dependency from the roomScreenCoordinator [4b5fbdf] Allow rooms to be selected from any other state [41dbd12] Move all missing coordinators to the RoomFlowCoordinator and state machines [f32431b] The UserSessionFlowCoordinator does not need to conform to the CoordinatorProtocol [0f07e87] Fix leaving a room dismissing the currently selected one when different [138385a] Rewind the navigation stack when re-selecting the same room (iPad) [0727eb9] Fix presenting different room details from the side menu on iPads [faf4cc6] Fix selecting the same room multiple times [fb3391d] Move room details presentation responsibility to the RoomFlowCoordinator. Fixed invitation flows. [fa2a68d] Rename RoomTimelineFlowCoordinator -> RoomFlowCoordinator [0c9c06b] Start moving things away from the RoomScreenCoordinator and into the RoomTimelineFlowCoordinator [86cbbdc] Introduce a RoomTimelineFlowCoordinator to deal with timeline related operations [9b2381b] Introduce the FlowCoordinatorProtocol
This is now done for the important flows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the application flows becoming more complex we should stop relying on screen coordinators from pushing other screens and instead extract that logic into dedicated flow coordinators.
Candidates are: the room coordinator, the create room coordinator and the room details coordinator
The text was updated successfully, but these errors were encountered: