-
Notifications
You must be signed in to change notification settings - Fork 11
/
rustic-flycheck.el
219 lines (196 loc) · 9.62 KB
/
rustic-flycheck.el
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
;;; rustic-flycheck.el --- Flycheck support -*-lexical-binding: t-*-
;;; Code:
(eval-when-compile (require 'let-alist))
(require 'flycheck)
(require 'json)
(require 'rustic)
(defcustom rustic-flycheck-clippy-params-stable "--message-format=json"
"Parameters for the flycheck clippy checker `rustic-clippy' when active toolchain is stable."
:type 'string
:group 'rustic-flycheck)
(defcustom rustic-flycheck-clippy-params-nightly "--message-format=json -Zunstable-options"
"Parameters for the flycheck clippy checker `rustic-clippy' when active toolchain is nightly."
:type 'string
:group 'rustic-flycheck)
(defun rustic-flycheck-dirs-list (start end)
"Return a list of directories from START (inclusive) to END (exclusive).
E.g., if START is '/a/b/c/d' and END is '/a', return the list
'(/a/b/c/d /a/b/c /a/b) in this order.
START and END are strings representing file paths. END should be
above START in the file hierarchy; if not, the list stops at the
root of the file hierarchy."
(let ((dirlist)
(dir (expand-file-name start))
(end (expand-file-name end)))
(while (not (or (equal dir (car dirlist)) ; avoid infinite loop
(file-equal-p dir end)))
(push dir dirlist)
(setq dir (directory-file-name (file-name-directory dir))))
(nreverse dirlist)))
(defun rustic-flycheck-get-cargo-targets (manifest)
"Return the list of available Cargo targets for the given project.
MANIFEST is the path to the Cargo.toml file of the project.
Calls `cargo metadata --no-deps --manifest-path MANIFEST
--format-version 1', parses and collects the targets for the
current workspace, and returns them in a list, or nil if no
targets could be found."
(let ((process-output-as-json
(lambda (program &rest args)
(rustic--with-temp-process-buffer
(let ((code-or-signal (apply 'process-file program nil '(t nil) nil args)))
(unless (equal code-or-signal 0)
;; Prevent from displaying "JSON readtable error".
(let* ((args (combine-and-quote-strings (cons program args)))
(error-message (if (stringp code-or-signal)
(format "%s terminated by %s." args code-or-signal)
(format "%s exited with %s." args code-or-signal))))
(user-error error-message)))
(goto-char (point-min))
(let ((json-array-type 'list)
(json-object-type 'alist))
(json-read))))))
(cargo (funcall flycheck-executable-find "cargo")))
(unless cargo
(user-error "flycheck-rust cannot find `cargo'. Please \
make sure that cargo is installed and on your PATH. See \
http://www.flycheck.org/en/latest/user/troubleshooting.html for \
more information on setting your PATH with Emacs."))
;; metadata contains a list of packages, and each package has a list of
;; targets. We concatenate all targets, regardless of the package.
(-when-let (packages (let-alist
(funcall process-output-as-json
cargo "metadata"
"--no-deps"
"--manifest-path" manifest
"--format-version" "1")
.packages))
(seq-map (lambda (pkg)
(let-alist pkg .targets))
packages))))
(defun rustic-flycheck-find-cargo-target (file-name)
"Return the Cargo build target associated with FILE-NAME.
FILE-NAME is the path of the file that is matched against the
`src_path' value in the list of `targets' returned by `cargo
read-manifest'.
Return an alist ((KIND . k) (NAME . n) (REQUIRED-FEATURES . rf))
where KIND is the target kind (lib, bin, test, example or bench),
NAME the target name (usually, the crate name), and REQUIRED-FEATURES is the
optional list of features required to build the selected target. If FILE-NAME
exactly matches a target `src-path', this target is returned. Otherwise, return
the closest matching target, or nil if no targets could be found.
See http://doc.crates.io/manifest.html#the-project-layout for a
description of the conventional Cargo project layout."
(-when-let* ((workspace (rustic-buffer-crate t))
(manifest (file-local-name (concat workspace "Cargo.toml")))
(packages (rustic-flycheck-get-cargo-targets manifest))
(targets (-flatten-n 1 packages)))
(let ((target
(or
;; If there is a target that matches the file-name exactly, pick
;; that one
(seq-find (lambda (target)
(let-alist target (string= file-name .src_path)))
targets)
;; Otherwise find the closest matching target by walking up the tree
;; from FILE-NAME and looking for targets in each directory. E.g.,
;; the file 'tests/common/a.rs' will look for a target in
;; 'tests/common', then in 'tests/', etc.
(car (seq-find
(lambda (pair)
(-let [((&alist 'src_path target-path) . dir) pair]
(file-equal-p dir (file-name-directory target-path))))
;; build a list of (target . dir) candidates
(-table-flat
'cons targets
(rustic-flycheck-dirs-list file-name workspace))))
;; If all else fails, just pick the first target
(car targets))))
;; If target is 'custom-build', we pick another target from the same package (see GH-62)
(when (string= "custom-build" (let-alist target (car .kind)))
(setq target (->> packages
;; find the same package as current build-script buffer
(--find (--any? (equal target it) it))
(--find (not (equal target it))))))
(when target
(let-alist target
(seq-filter (lambda (kv) (cdr kv))
(list (cons 'kind (rustic-flycheck-normalize-target-kind .kind))
(cons 'name .name)
(cons 'required-features .required-features))))))))
(defun rustic-flycheck-normalize-target-kind (kinds)
"Return the normalized target name from KIND.
KIND is a list of target name as returned by `cargo metadata',
which do not necessarily correspond to to target names that can
be passed as argument to `cargo rustc'.
The normalization returns a valid cargo target based on KINDS."
;; Assumption: we only care about the first kind name. Multiple kinds only
;; seem to happen for library crate types, and those all maps to the same
;; `lib' target.
(pcase (car kinds)
(`"dylib" "lib")
(`"rlib" "lib")
(`"staticlib" "lib")
(`"cdylib" "lib")
(`"proc-macro" "lib")
(_ (car kinds))))
;;;###autoload
(defun rustic-flycheck-setup ()
"Setup Rust in Flycheck.
If the current file is part of a Cargo project, configure
Flycheck according to the Cargo project layout."
(interactive)
;; We should avoid raising any error in this function, as in combination
;; with `global-flycheck-mode' it will render Emacs unusable (see
;; https://github.com/flycheck/flycheck-rust/issues/40#issuecomment-253760883).
(with-demoted-errors "Error in rustic-flycheck-setup: %S"
(-when-let* ((file-name (buffer-file-name))
(target (rustic-flycheck-find-cargo-target file-name)))
(let-alist target
(setq-local flycheck-rust-features .required-features)
(setq-local flycheck-rust-crate-type .kind)
(setq-local flycheck-rust-binary-name .name)))))
(defun rustic-flycheck-nightly-p ()
"Check if active toolchain is a nightly toolchain."
(let ((tc (shell-command-to-string "rustup show active-toolchain")))
(string-match-p "^nightly" (car (split-string tc)))))
(defun rustic-flycheck-clippy-params ()
"Return clippy parameters for flycheck depending on the active toolchain."
(if (rustic-flycheck-nightly-p)
rustic-flycheck-clippy-params-nightly
rustic-flycheck-clippy-params-stable))
(defun rustic-flycheck-rust-manifest-directory ()
"This function looks up the workspace root instead of the crate root
so error highlighting also works with multi-crate projects."
(rustic-buffer-workspace))
(flycheck-define-checker rustic-clippy
"A Rust syntax checker using clippy.
See URL `https://github.com/rust-lang-nursery/rust-clippy'."
:command ("cargo" "clippy" (eval (split-string (rustic-flycheck-clippy-params))))
:error-parser flycheck-parse-cargo-rustc
:error-filter flycheck-rust-error-filter
:error-explainer flycheck-rust-error-explainer
:modes rustic-mode
:predicate flycheck-buffer-saved-p
:working-directory (lambda (_) (rustic-flycheck-rust-manifest-directory))
:verify
(lambda (_)
(and buffer-file-name
(let ((has-toml (rustic-flycheck-rust-manifest-directory))
(has-clippy (flycheck-rust-cargo-has-command-p "clippy")))
(list
(flycheck-verification-result-new
:label "Clippy"
:message (if has-clippy "Found"
"Cannot find the `cargo clippy' command")
:face (if has-clippy 'success '(bold warning)))
(flycheck-verification-result-new
:label "Cargo.toml"
:message (if has-toml "Found" "Missing")
:face (if has-toml 'success '(bold warning))))))))
(add-hook 'rustic-mode-hook 'flycheck-mode)
(add-hook 'flycheck-mode-hook #'rustic-flycheck-setup)
;; turn off flymake
(add-hook 'rustic-mode-hook 'flymake-mode-off)
;;; _
(provide 'rustic-flycheck)
;;; rustic-flycheck.el ends here