Fixed build error and test error

email2vimalraj · Jun 26, 2017 · ed0b51f · ed0b51f
1 parent 4261e73
commit ed0b51f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 13 deletions.
diff --git a/src/main/java/com/cucumber/listener/ExtentCucumberFormatter.java b/src/main/java/com/cucumber/listener/ExtentCucumberFormatter.java
@@ -42,15 +42,11 @@ private static void setExtentHtmlReport(File file) {
         if (htmlReporter != null) {
             return;
         }
-        try {
-            if (!file.exists()) {
-                file.getParentFile().mkdirs();
-            }
-        } catch (NullPointerException e) {
+        if (file == null || file.getPath().isEmpty()) {
             file = new File(ExtentProperties.INSTANCE.getReportPath());
-            if (!file.exists()) {
-                file.getParentFile().mkdirs();
-            }
+        }
+        if (!file.exists()) {
+            file.getParentFile().mkdirs();
         }
         htmlReporter = new ExtentHtmlReporter(file);
     }
@@ -65,7 +61,7 @@ private static void setExtentReport() {
         }
         extentReports = new ExtentReports();
         ExtentProperties extentProperties = ExtentProperties.INSTANCE;
-        if (extentProperties.getExtentXServerUrl() != null || !extentProperties.getExtentXServerUrl().isEmpty()) {
+        if (extentProperties.getExtentXServerUrl() != null) {
             String extentXServerUrl = extentProperties.getExtentXServerUrl();
             try {
                 URL url = new URL(extentXServerUrl);

diff --git a/src/test/java/com/cucumber/runner/RunCukesTest.java b/src/test/java/com/cucumber/runner/RunCukesTest.java
@@ -23,8 +23,8 @@ public class RunCukesTest {
     @BeforeClass
     public static void setup() {
         ExtentProperties extentProperties = ExtentProperties.INSTANCE;
-        extentProperties.setExtentXServerUrl("http://localhost:1337");
-        extentProperties.setProjectName("MyProject");
+//        extentProperties.setExtentXServerUrl("http://localhost:1337");
+//        extentProperties.setProjectName("MyProject");
         extentProperties.setReportPath("output/myreport.html");
     }
 

diff --git a/src/test/java/com/cucumber/runner/TestNGCukesRunner.java b/src/test/java/com/cucumber/runner/TestNGCukesRunner.java
@@ -18,8 +18,8 @@ public class TestNGCukesRunner extends AbstractTestNGCucumberTests {
     @BeforeClass
     public  static void setup() {
         ExtentProperties extentProperties = ExtentProperties.INSTANCE;
-        extentProperties.setExtentXServerUrl("http://localhost:1337");
-        extentProperties.setProjectName("TestNGProject");
+//        extentProperties.setExtentXServerUrl("http://localhost:1337");
+//        extentProperties.setProjectName("TestNGProject");
         extentProperties.setReportPath("output/myreport.html");
     }