Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nocontainer param no longer hides the container #923

Open
runspired opened this issue Feb 11, 2022 · 2 comments
Open

nocontainer param no longer hides the container #923

runspired opened this issue Feb 11, 2022 · 2 comments

Comments

@runspired
Copy link

regardless of checkbox state the container is shown.

@runspired
Copy link
Author

just coming back to this to see if anyone has looked into why? it's been broken almost 2 years.

@runspired runspired changed the title hideContainer no longer hides the container nocontainer param no longer hides the container Apr 15, 2022
@runspired
Copy link
Author

The answer is that these lines:

let testContainer = document.getElementById('ember-testing-container');
if (!testContainer) {
return;
}

run before the DOM is fully constructed.

in my test's index.html I needed to move

    <div id="qunit"></div>
    <div id="qunit-fixture">
      <div id="ember-testing-container">
        <div id="ember-testing"></div>
      </div>
    </div>

above

    <script src="/testem.js" integrity=""></script>
    <script src="{{rootURL}}assets/vendor.js"></script>
    <script src="{{rootURL}}assets/test-support.js"></script>

    <script src="{{rootURL}}assets/dummy.js"></script>
    <script src="{{rootURL}}assets/tests.js"></script>

This is a funny "gotya" because everything about the tests continues to work as normal except this one feature. I suspect that feature should be made to grab the html element lazily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant