Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo brushed flipoveraftercrash #357

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mywinchester
Copy link

  • Removed the old newbeedrone brushless motor flip over after crash code, which was not protected by macro definitions and therefore risked affecting the underlying layers.
  • Restore BOXUSER4 named USER4, the new changes do not occupy PINIOBOX.
  • Rewrite the brushed flipoveraftercrash function, the new change uses macro definition USE_BRUSHED_FLIPOVERAFTERCRASH to divide, and use macro definition BRUSHED_REVERSE_PIN to define the used pin.
  • The BRUSHED_REVERSE pin resource has been added to the CLI so that the pin definition can be changed or viewed through the CLI.

Gordon Mak added 2 commits September 17, 2020 11:08
This change does not use macro definitions to segment the code, which may affect the underlying risk.
- Use a general io to control motor forward and reverse (need special esc)
- Added this pin to cli resource when macro activated
@nerdCopter
Copy link
Member

nerdCopter commented Sep 21, 2020

@mywinchester , can you update your fork (sync) and merge master into this?

git remote add upstream https://github.com/emuflight/EmuFlight.git
git remote set-url --push upstream disabled
git remote -v #view remotes

git checkout master
git pull upstream master

git push origin #update fork's master

git checkout redo_brushed_flipoveraftercrash
git merge master #merge master into branch

git push #push updated branch

@Quick-Flash
Copy link
Member

Thanks for this, it should have been done a long while ago, however, I have two questions/suggestions, shouldn't we still allow 3d mode to be enabled? and it doesn't look like the current target which supports this action will work with this code until we change that code as well. Could you make the changes to support 3d and support the newbeedrone brushed pro flight controller with this option of turtle mode?

@mywinchester
Copy link
Author

@Quick-Flash Well, maybe we can implement it in the next feature patch.

@mywinchester mywinchester force-pushed the redo_brushed_flipoveraftercrash branch from ac33f88 to 5b2dcf8 Compare January 11, 2021 06:49
@nerdCopter
Copy link
Member

nerdCopter commented Feb 22, 2021

Feb 21 QuickFlash: i've made targets using that pull request and they don't fly -- for records so we stop referencing this PR internally until fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants