app is being passed into AsyncClient without me doing it, resulting in a deprecation warning

[mdreisinger]

I am getting this deprecation warning and I don't know how to resolve it, because I am not passing app into AsyncClient:

/.venv/lib/python3.11/site-packages/httpx/_client.py:680: DeprecationWarning: The 'app' shortcut is now deprecated. Use the explicit style 'transport=WSGITransport(app=...)' instead.
    warnings.warn(message, DeprecationWarning)

from fastapi import FastAPI, Depends, testclient
from httpx import AsyncClient

app = FastAPI()


async def get_http_client():
    async with AsyncClient() as client:
        yield client


@app.get("/")
async def demo_endpoint(
    http_client: AsyncClient = Depends(get_http_client)
):
    return "hello world"



def test_demo_endpoint():
    # This test results in the DeprecationWarning.
    test_client = testclient.TestClient(app)
    response = test_client.get("/")
    assert response.text == '"hello world"'

[gpspake]

I was about to make a post about this as well. You get the warning even with the out of the box fastAPI example:

from fastapi.testclient import TestClient
from main import app

client = TestClient(app)


def test_read_root():
    response = client.get("/")
    assert response.status_code == 200
    assert response.json() == {"Hello": "World"}

results in:

../../.pyenv/versions/3.12.2/envs/cds/lib/python3.12/site-packages/httpx/_client.py:680
  /Users/gpspake/.pyenv/versions/3.12.2/envs/cds/lib/python3.12/site-packages/httpx/_client.py:680: DeprecationWarning: The 'app' shortcut is now deprecated. Use the explicit style 'transport=WSGITransport(app=...)' instead.
    warnings.warn(message, DeprecationWarning)

I can't find a clear explanation of how to handle this or context for why I'm getting the error or how to fix it. Is this something that needs to be changed in fastAPI?

• Here's the commit cabd1c0
• Deprecation in changelog https://github.com/encode/httpx/blob/master/CHANGELOG.md#deprecated