Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Educational BoosterPack Screen Library // explicit check for board support #654

Open
adrianF-TI opened this issue Jun 30, 2015 · 3 comments

Comments

@adrianF-TI
Copy link

For each new Energia release, we need to update the explicit list of supported boards. For example, MSP432 is not in the current Screen_HX8353E.cpp file as a supported board, thus compilation fails. However, by simply adding it to the #if defined() section, it works just fine.

@adrianF-TI
Copy link
Author

Also seems to work with MSP430FR6989 LaunchPad on Energia v16

@rei-vilo
Copy link
Member

rei-vilo commented Jul 1, 2015

The #if defined() is required to check the LaunchPad has a 40-pin BoosterPack connector, as _pinDataCommanduses pin 31.

Now, we could define another set of variables for the BoosterPack capability to each LaunchPad, for example HAS_20_PIN_BOOSTERPACK and HAS_40_PIN_BOOSTERPACK.

The resulting Screen_HX8353E.cpp would be then

#if defined(HAS_40_PIN_BOOSTERPACK) 
// ...
#else
#error Platform not supported
#endif

This would ease the test and save updates every-time a new LaunchPad is available.

@rei-vilo
Copy link
Member

rei-vilo commented Jul 1, 2015

@adrianF-TI

See pull-request 7dce178 on #659 Added HAS_40_PIN_BOOSTERPACK and HAS_20_PIN_BOOSTERPACK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants