Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With Expo-router, HoldItem clicked moves the height of the header #101

Open
KOWLOR opened this issue May 29, 2023 · 2 comments
Open

With Expo-router, HoldItem clicked moves the height of the header #101

KOWLOR opened this issue May 29, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@KOWLOR
Copy link

KOWLOR commented May 29, 2023

Describe the bug
Using Expo-router, <HolItem /> translates on the Y axis the height if a header of a <Stack />, even if the prop disabledMove is set.

To Reproduce
Steps to reproduce the behavior:

  1. Create a basic expo-router file based routing in /app create a _layout.tsx
/app
  _layout.tsx
  index.tsx
  1. In _layout.tsx, create a basic that returns a navigation
return (<>
  <Stack screenOptions={{ headerShown: true }}>
    <Stack.Screen name="index" options={{ headerLargeTitle: false }} />
  </Stack>
</>
)
  1. In index.tsx, use <HoltItem />
<HoldItem
  activateOn="tap"
  disableMove
  items={[ 
    { text: 'Reply', onPress: () => {} },
    { text: 'Edit', onPress: () => {} },
    { text: 'Delete', onPress: () => {} },
  ]}>
  <Text>My Action</Text>
</HoldItem>
  1. Click on My Action, this text will translate on Y axis to a distance that is equal to the header's height.

Expected behavior
The My Action text should not move.

Additional context
There is no move by setting headerShown: false in the <Stack />, but I need that header.

@KOWLOR KOWLOR added the bug Something isn't working label May 29, 2023
@KOWLOR KOWLOR changed the title With Expo-router, HoldItem clicked moves the height of the header With Expo-router, HoldItem clicked moves the height of the header May 29, 2023
@fukemy
Copy link

fukemy commented Jun 13, 2023

everyone has leaved this lib

@albertpco
Copy link

@fukemy theres no other good libs that work with expo, v sad lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants