Optimize building and casting of EnsoMultiValue #11924
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
4e6,
hubertp and
Akirathan
as code owners
JaroslavTulach
changed the title
2 tasks
JaroslavTulach
commented
Dec 20, 2024
| go 0 0 | ||
|
|
||
|
|
||
| make_vector type n = |
There was a problem hiding this comment.
A dedicated benchmark for EnsoMultiValue instances based on the idea of ArrayProxy one. Currently the more complicated benchmarks refuse to compile and the compiler bails out. The initial results are:
sbt:enso> runtime-benchmarks/benchOnly MultiValueBenchmarks
Benchmark Mode Cnt Score Error Units
MultiValueBenchmarks.sumOverComplexAndFloat5 avgt 5 214.330 ± 4.179 ms/op
MultiValueBenchmarks.sumOverComplexFloatRecastedToFloat3 avgt 5 219.803 ± 11.872 ms/op
MultiValueBenchmarks.sumOverFloat1 avgt 5 0.079 ± 0.006 ms/op
MultiValueBenchmarks.sumOverFloatAndComplex6 avgt 5 219.525 ± 6.393 ms/op
MultiValueBenchmarks.sumOverFloatComplexRecastedToFloat4 avgt 5 203.788 ± 9.843 ms/op
MultiValueBenchmarks.sumOverInteger0 avgt 5 0.074 ± 0.001 ms/op
After 630ec62 the results are better:
MultiValueBenchmarks.sumOverComplexAndFloat5 avgt 5 30.109 ± 0.661 ms/op
MultiValueBenchmarks.sumOverComplexFloatRecastedToFloat3 avgt 5 26.988 ± 0.446 ms/op
MultiValueBenchmarks.sumOverFloat1 avgt 5 0.078 ± 0.003 ms/op
MultiValueBenchmarks.sumOverFloatAndComplex6 avgt 5 27.821 ± 0.856 ms/op
MultiValueBenchmarks.sumOverFloatComplexRecastedToFloat4 avgt 5 27.961 ± 0.263 ms/op
MultiValueBenchmarks.sumOverInteger0 avgt 5 0.078 ± 0.002 ms/op
and there are no bailouts. Time to really speed things up.
There was a problem hiding this comment.
Some speedup achieved...
…nsoMultiValue instance
JaroslavTulach
commented
Dec 21, 2024
| * The <b>base benchmark</b> for this suite. Measures how much it takes to access an Atom in a | ||
| * Vector, read {@code re:Float} field out of it and sum all of them together. | ||
| */ | ||
| @Benchmark |
There was a problem hiding this comment.
This is now the base benchmark. The results after 4dacf53 are:
# the base one
MultiValueBenchmarks.sumOverComplexBaseBenchmark0 avgt 5 0.139 ± 0.013 ms/op
# these two are supposed to be faster
MultiValueBenchmarks.sumOverInteger1 avgt 5 0.065 ± 0.003 ms/op
MultiValueBenchmarks.sumOverFloat2 avgt 5 0.073 ± 0.002 ms/op
# these should catch up with sumOverComplexBaseBenchmark0 one day
MultiValueBenchmarks.sumOverComplexAndFloat5 avgt 5 8.580 ± 0.326 ms/op
MultiValueBenchmarks.sumOverComplexFloatRecastedToFloat3 avgt 5 9.118 ± 0.483 ms/op
MultiValueBenchmarks.sumOverFloatAndComplex6 avgt 5 8.110 ± 0.160 ms/op
MultiValueBenchmarks.sumOverFloatComplexRecastedToFloat4 avgt 5 9.393 ± 0.648 ms/op
still 60 times slower than it should be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR will address #11846 by introducing an internal
MultiTypereplacingType[], but guaranteeing quick (via==) comparisons necessary to built various inline caches.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,