Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segfault when ship is not reachable #25

Closed
cc32d9 opened this issue Aug 28, 2023 · 1 comment
Closed

segfault when ship is not reachable #25

cc32d9 opened this issue Aug 28, 2023 · 1 comment

Comments

@cc32d9
Copy link

cc32d9 commented Aug 28, 2023

I upgraded the node from an existing database, and when I started it, the ship was not available. The node coredumped.

@yarkinwho
Copy link
Contributor

We have --ship-max-retry to control how many times we will retry connecting to ship. It's defaulted to 0 which means the system will give up and exit directly. Therefore, exit on a unreachable ship is working as intended.

But yes we should make sure the exit process is more graceful and try not triggering segfaults (current way to exit seems will eventually lead to segfault). tracked by #29

@yarkinwho yarkinwho closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants