Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce 2x buffer for gas limit #47

Closed
arhag opened this issue Sep 19, 2023 · 0 comments · Fixed by #48 or #57
Closed

Reduce 2x buffer for gas limit #47

arhag opened this issue Sep 19, 2023 · 0 comments · Fixed by #48 or #57
Assignees

Comments

@arhag
Copy link
Member

arhag commented Sep 19, 2023

Depends on eosnetworkfoundation/eos-evm-node#50 and eosnetworkfoundation/eos-evm-contract#663.

Right now the frontend sets the gas limit to twice the estimated gas. This is to workaround issues in the EOS EVM Node which underestimates the appropriate gas estimate (eosnetworkfoundation/eos-evm-node#50) and in the EOS EVM Contract which requires a higher gas limit than should actually be necessary (eosnetworkfoundation/eos-evm-contract#663).

Once those two issues are resolved, the frontend can be updated to reduce the buffer it uses to 10%. Some buffer is still desired because evolving state could cause the contract execution to go down slightly different code paths which end up consuming a little more gas.

@arhag arhag added this to the Bridge Frontend 0.9.0-rc2 milestone Sep 20, 2023
@arhag arhag linked a pull request Sep 21, 2023 that will close this issue
@arhag arhag linked a pull request Sep 29, 2023 that will close this issue
@arhag arhag closed this as completed Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment