Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore p2p messages of unknown types #126

Open
cc32d9 opened this issue Apr 22, 2022 · 0 comments
Open

ignore p2p messages of unknown types #126

cc32d9 opened this issue Apr 22, 2022 · 0 comments

Comments

@cc32d9
Copy link
Contributor

cc32d9 commented Apr 22, 2022

In current implementation, if a node receives a message of unknown type, it throws an error and disconnects the socket:

fc::raw::unpack( ds, msg );

If the plugin is modified to ignore unknown message types, it would allow extending the protocol without having to upgrade the whole network and activate a feature. One of examples is the fast finality proposal which would send block confirmations in a new type of message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant