Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

motorRecord.html: out-of-date PID scaling info for OMS controllers #210

Open
kmpeters opened this issue Oct 9, 2023 · 0 comments
Open

motorRecord.html: out-of-date PID scaling info for OMS controllers #210

kmpeters opened this issue Oct 9, 2023 · 0 comments

Comments

@kmpeters
Copy link
Member

kmpeters commented Oct 9, 2023

motorRecord.hmtl contains out-of-date information about the PID gain scaling for OMS controllers:

motor/docs/motorRecord.html

Lines 2823 to 2824 in d1ed86f

For all OMS controllers;  CKP = 1999.9 * PCOF, CKI = 1999.9 * ICOF, CKD =
1999.9 * DCOF.

A scaling factor of 32767.0 is used for MAXv controllers:

https://github.com/epics-motor/motorOms/blob/dca9b664904de6378854844882605179663a30e7/omsApp/src/devOmsCom.cc#L450-L457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kmpeters