Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Search in Advanced Filter not working when selecting filter item #137

Open
jaysencpp opened this issue Oct 24, 2022 · 1 comment
Open
Assignees
Labels
bug Something isn't working LHF Low hanging fruits power-bi

Comments

@jaysencpp
Copy link
Contributor

jaysencpp commented Oct 24, 2022

Expected Behavior

When using the search functionality in the advanced filter, the user should be able to select the filter item they searched for.

Current Behavior

After searching, and the user is about to select a filter item, the Filter Group component rerenders, and the user won't be able to select any items. Relevant issue

Possible Solution

Remove onBlur on the Search component. Introduce a useClickOutside hook. Attach a ref for the whole FilterGroup the hook listens to, and if the user clicks outside of the entire FilterGroup, search component will be closed and hidden.

Steps to Reproduce

  1. Go to PBI report/Work space
  2. Open Advanced filter
  3. Choose a filter group with search option
  4. Search for something, try to select a filter item.
@jaysencpp jaysencpp added bug Something isn't working power-bi labels Oct 24, 2022
@jaysencpp jaysencpp changed the title PBI Search in Advanced Filter not working when selecting filter item Search in Advanced Filter not working when selecting filter item Oct 28, 2022
@Gustav-Eikaas Gustav-Eikaas added the LHF Low hanging fruits label Jan 6, 2023
@Gustav-Eikaas Gustav-Eikaas self-assigned this Jan 6, 2023
@Gustav-Eikaas
Copy link
Contributor

Confirmed to still be an issue. Low value in fixing but confirmed bug

@Gustav-Eikaas Gustav-Eikaas changed the title Search in Advanced Filter not working when selecting filter item 🐛 Search in Advanced Filter not working when selecting filter item May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working LHF Low hanging fruits power-bi
Projects
None yet
Development

No branches or pull requests

4 participants