Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambigious imports/inferred file extensions TS (might make package unusable in other projects if not fixed) #552

Open
Tracked by #545
Gustav-Eikaas opened this issue Dec 6, 2023 · 0 comments

Comments

@Gustav-Eikaas
Copy link
Contributor

Gustav-Eikaas commented Dec 6, 2023

Context

When creating npm packages you have to transpile them without knowing the hosts environment. This can result in major compatibility issues if not done correctly.

Setting the following compilerOptions in tsconfig

module: NodeNext,
moduleResolution: NodeNext

Problem

Today we use the

import { add } from './math' 

But we should use

import { add } from './math.js'

Reference

https://www.typescriptlang.org/docs/handbook/modules/theory.html#module-resolution-for-libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant