Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include copy time on plotman analyze #704

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Include copy time on plotman analyze #704

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
752fe62
Added: Copy time column in analyzer
ReaktorDTR May 30, 2021
a28d927
Merge branch 'development' into total_time_includes_copy_time
ReaktorDTR May 30, 2021
056bed2
Update: Calculate total in the end of log file
ReaktorDTR May 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions src/plotman/analyzer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import os
import re
import statistics
import sys

import texttable as tt

Expand All @@ -18,6 +17,8 @@ def analyze(logfilenames, clipterminals, bytmp, bybitfield):
n_sorts = 0
n_uniform = 0
is_first_last = False
total_time = 0
copy_time = 0

# Read the logfile, triggering various behaviors on various
# regex matches.
Expand Down Expand Up @@ -89,14 +90,27 @@ def analyze(logfilenames, clipterminals, bytmp, bybitfield):
if clipterminals and is_first_last:
pass # Drop this data; omit from statistics.
else:
data.setdefault(sl, {}).setdefault('total time', []).append(float(m.group(1)))
for phase in ['1', '2', '3', '4']:
data.setdefault(sl, {}).setdefault('phase ' + phase, []).append(phase_time[phase])
data.setdefault(sl, {}).setdefault('%usort', []).append(100 * n_uniform // n_sorts)
total_time = float(m.group(1))

# Copy Time. Sample log line:
# Copy time = 958.194 seconds. CPU (6.290%) Sat May 22 17:39:57 2021
m = re.search(r'^Copy time = (\d+.\d+) seconds.*', line)
if m:
copy_time = float(m.group(1))

# Rename plot. Sample log line:
# Renamed final file from "/mnt/d1/a4.plot.2.tmp" to "/mnt/d2/a4.plot"
m = re.search(r'^Renamed final file.*', line)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this present regardless of what combinations of tmp/tmp2/dst are specified?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and if tmp same as dst it will show 0 sec because of simple renaming.

if m:
data.setdefault(sl, {}).setdefault('copy time', []).append(copy_time)
data.setdefault(sl, {}).setdefault('total time', []).append(total_time + copy_time)
for phase in ['1', '2', '3', '4']:
data.setdefault(sl, {}).setdefault('phase ' + phase, []).append(phase_time[phase])
data.setdefault(sl, {}).setdefault('%usort', []).append(100 * n_uniform // n_sorts)

# Prepare report
tab = tt.Texttable()
all_measures = ['%usort', 'phase 1', 'phase 2', 'phase 3', 'phase 4', 'total time']
all_measures = ['%usort', 'phase 1', 'phase 2', 'phase 3', 'phase 4', 'copy time', 'total time']
headings = ['Slice', 'n'] + all_measures
tab.header(headings)

Expand Down