Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does reviewdog not fail the run? #116

Closed
karl-johan-grahn opened this issue Jan 17, 2024 · 1 comment
Closed

Why does reviewdog not fail the run? #116

karl-johan-grahn opened this issue Jan 17, 2024 · 1 comment

Comments

@karl-johan-grahn
Copy link

I'm running a spell check with:

      - name: Spell check
        uses: errata-ai/vale-action@v2.0.1
        with:
          version: 3.0.5
          fail_on_error: true
          files: content
        env:
          GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}

and vale reports three errors, however reviewdog does not fail the job even though -fail-on-error=true: https://github.com/stakater/secrets-docs/actions/runs/7562848951/job/20594324785
@karl-johan-grahn
Copy link
Author

Duplicate of #103

@karl-johan-grahn karl-johan-grahn mentioned this issue Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@karl-johan-grahn