Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Hardcoded Test Values to Appropriate Location #622

Open
2 tasks
Kasshern opened this issue Jan 25, 2023 · 2 comments
Open
2 tasks

Move Hardcoded Test Values to Appropriate Location #622

Kasshern opened this issue Jan 25, 2023 · 2 comments
Assignees
Labels
🙅 blocked 🙅 Blocked by something (put note in comments)

Comments

@Kasshern
Copy link
Collaborator

Kasshern commented Jan 25, 2023

Overview

Please see #614 (comment) and complete ONLY one of the following two optional tasks with regards to all hard coded values within all controller tests:

  1. value to be moved into either a separate test setup or a configuration file
  2. move the hardcoded values into a configuration file that is loaded into the module
  3. Introduce a mock library to avoid physical creation of mocks and read mock data from jsons

Reference

Questions

-None

Assumptions

  • None

Acceptance

  • All hardcoded values within tests should be collectively altered in a fashion described in either option 1 or 2 from above. The same option should be applied to all hardcoded values within the scope of this issue.

Tasks

  • All hardcoded values within controller tests have been moved into either a separate test setup or a configuration file
    OR
  • All hardcoded values within controller tests have been moved into a configuration file that is loaded into the module
@Ybittan Ybittan self-assigned this Jan 31, 2023
@Ybittan
Copy link
Member

Ybittan commented Feb 9, 2023

@Ybittan
Copy link
Member

Ybittan commented Apr 20, 2023

Clarification: This work has been completed in this branch, but is pending mock prisma PR to be merged first.

@Ybittan Ybittan added the 🙅 blocked 🙅 Blocked by something (put note in comments) label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙅 blocked 🙅 Blocked by something (put note in comments)
Projects
None yet
Development

No branches or pull requests

2 participants