-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
record IP addresses and ZIPcodes of contributions. #67
Comments
@sanchaymittal is this easy to add? |
We are already receiving ZIPCodes right now, as for Ip addresses it's kinda tricky. For payment, we are using stripe components and the post API to add donation can only be triggered by stripe when a payment occurs. |
why is IP addresses tricky? feel free to use this get_ip method from the gitcoin codebase
|
For security reasons, we are not making a post request from the frontend when a donation happens. Post request is made by stripe when a donation happens, we have a webhook for that. That's why I'm saying it's tricky to include Ipaddress when a donation/contribution happens in the database. |
oh i see; thanks for the explanation. yes that would be good, pls do. IP addreses will be important to know for anti sybil reasons |
Sure, But this will take some time as we have to add an API for making this post-call and a separate DB structure. Can't rush during production. |
can we please record IP addresses and ZIPCodes of credit cards of contributions; just in case someone sybil attacks the system.. we will need to have this info so we can remediate.
The text was updated successfully, but these errors were encountered: