Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect cntbn.cc values #45

Open
joewdavies opened this issue Nov 16, 2024 · 5 comments
Open

Incorrect cntbn.cc values #45

joewdavies opened this issue Nov 16, 2024 · 5 comments
Labels

Comments

@joewdavies
Copy link

joewdavies commented Nov 16, 2024

It seems that some cntbn features do not have the correct cc property:

image

I discovered this while testing CSS in eurostat-map by targeting and hiding boundary elements that had 'oth' but not 'co' or 'cc':

            .em-bn-oth:not(.em-bn-co):not(.em-bn-cc) {
                stroke-width: 0 !important;
            }

image

It would seem that (at least for NUTS2) all cntbn have cc set to F

@joewdavies joewdavies added the bug label Nov 16, 2024
@hannesaddec
Copy link

hannesaddec commented Nov 18, 2024 via email

@joewdavies
Copy link
Author

This file:
https://raw.githubusercontent.com/eurostat/Nuts2json/master/pub/v2/2024/3035/60M/2.json

Some example IDs in cntbn where this occurs are 131 and 156.

@hannesaddec
Copy link

hannesaddec commented Nov 18, 2024 via email

@joewdavies
Copy link
Author

joewdavies commented Nov 18, 2024

  1. They are incorrect (please read the issue carefully).
    image

  2. No, the point is that they are incorrect.
    image

  3. I dont know what you mean by empty segments.

  4. Yes, I am sure.

Please refrain from filling comments with emails. Its messy! Also, you did not attach a screenshot.

@joewdavies
Copy link
Author

Michael is aware of the issue and will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants