New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Items in the cart still appear after customer log out #580

Open

MarwanRadwan7 opened this issue Jul 10, 2024 · 1 comment

Assignees

MarwanRadwan7 commented Jul 10, 2024 •

edited

Loading

Describe the bug

When a user enter the website generate a cookie/session and saved under the name of sid in the browser with an age of 1 day.
The cookie is attached to the cart whether the client is logged in or just a guest. So when an existed customer in our database log in and then logs out the cart is still shows the the data after log out.

To Reproduce
Steps to reproduce the behavior:

Go to the website.
log in as a customer.
Add some products to the cart.
log out. Then you will see that items is still showing in the cart.

Background (please complete the following information):

NodeJS Version 20.13
Postgres Version 16
EverShop Version 1.1.0
OS: Ubuntu 24 LTS
Browser: Chrome

Additional context
I can help to provide a solution to this problem.

The text was updated successfully, but these errors were encountered:

MarwanRadwan7 assigned treoden

Author

MarwanRadwan7 commented Jul 10, 2024

Hello, @treoden
I can help to provide a solution to this problem in a PR.

MarwanRadwan7 mentioned this issue

Fix cart items after logout #584

Open

10 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment