LibreJS compatibility #103
Conversation
public/directory.html
Outdated
| @@ -6,6 +6,8 @@ | |||
| <title>listing directory {directory}</title> | |||
| <style>{style}</style> | |||
| <script> | |||
| // @license magnet:?xt=urn:btih:d3d9a9a6595521f9666a5e94cc830dab83b65699&dn=expat.txt Expat | |||
There was a problem hiding this comment.
It's not clear what the purpose of this is, but regardless, this does not link to the correct license. Following this, it pulls the following content, which has the wrong copyright information: http://www.jclark.com/xml/copying.txt
Out license is located at https://github.com/expressjs/serve-index/blob/master/LICENSE generally.
There was a problem hiding this comment.
The purpose is for the LibreJS extension to recognize the license. If this is not included, alongside // @license-end, it will not be loaded.
The magnet used is what is listed here in the documentation for the extension as to what it detects, but I can check and see if I can make the magnet reflect the actual copyright information.
There was a problem hiding this comment.
Gotcha. So yea, I used torrent to load the magnet link there and that is what I got. It would be confusing for the loaded source to say that is the license when it is not. As a reminder, the clause in our license requires that the copyright information must stay intact.
There was a problem hiding this comment.
Just gave it a test and the magnet works as expected, license recognized. Adding to the PR. Would a squash be helpful?
EDIT: This was probably cache.
There was a problem hiding this comment.
Thanks! So I have been waiting a long time and so far none of the trackers are able to locate that given bittorrent by the info hash in the magnet link. Are you currently seeding this torrent? Perhapd can you send the bittorrent metadata file that hash points to so I can at least verify this points to the right thing?
There was a problem hiding this comment.
Sorry, this somehow totally slipped my inbox. So, it's definitely not pointing to anything right now.
Regardless, I've found a better way to do this that AFAIK also retains copyright information and doesn't need a magnet. Will update the PR when I'm not busy 👍
As this middleware is under the MIT license, it is considered "free software". As such, this pull requests allows
directory.htmlto be loaded with the LibreJS extension, making it aware it is under the MIT license.