Add sorting option #37
Conversation
when passing a `sorting` key to the options the file listings can be served on other keys than name, additionally the sorting oder can be reversed by prefixing the key with a `-`
|
Don't worry about the test failure, I see what it is and something I need to fix :) As for the sort, that is awesome, but why not just let the option be a function instead of a string? When customizing sorting, I've seen most people want to be able to keep folders separate, mix the folders and files, sort by name case sensitive, sort by name case insensitive, and use Intl functions to sort foreign language names correctly. The new sort functionality should at least be able to achieve these popular things :) |
|
I thought the same thing but somehow decided to go for the stat keys. Passing a function for sorting sounds good though. Would you disable |
instead of limiting sorting options to the keys in stat, enable passing a function so sorting is as flexible as possible
I just ran into the same issue as #35, so I thought I'd give it a go. Instead of defining custom sort options I went for enabling sorting all keys available on
fs.Stat.Edit: I am a little confused as far as the CI errors go, as they seem to be installation problems (the tests don't run in the first place), yet all I did to ensure passing CI is running the tests locally on my machine (node 4.1.2) so they still might fail in other envs. Any insight on what exactly is failing is welcome.