Set CREATE_NO_WINDOW flag when executing Git hooks

[icorbrey]

This Pull Request makes changes to accommodate GUI functionality in GitButler (see: gitbutlerapp/gitbutler#4982).

It changes the following:

• Set the CREATE_NO_WINDOW flag when executing Git hooks on Windows.

I followed the checklist:

• I added unittests
• I ran make check without errors
• I tested the overall application
• I added an appropriate item to the changelog

[icorbrey]

I've tested this functionality using a dev build of GitButler with the git2-hooks dependency pointed at my local copy of gitui. Please let me know if I need to do anything else to get this merged, it bothers me when using GitButler with Lefthook and I'd like to be able to get it fixed!

[extrawurst]

Thanks for the contribution! Can you fix the ci issues?

[icorbrey]

Sure thing!

[icorbrey]

@extrawurst that should fix it, I had forgotten to ensure this was a noop when you're not on Windows

[icorbrey]

@extrawurst out of curiosity, do you have an idea of when the next release will be? Also, I believe the CI workflow requires your approval again.

[extrawurst]

can we add a link here to some place that documents this magic number? maybe even use a local constant that is named equally CREATE_NO_WINDOW?

[icorbrey]

I went ahead and added the following to CommandExt:

/// The process is a console application that is being run without a
/// console window. Therefore, the console handle for the application is
/// not set.
///
/// This flag is ignored if the application is not a console application,
/// or if it used with either `CREATE_NEW_CONSOLE` or `DETACHED_PROCESS`.
///
/// See: https://learn.microsoft.com/en-us/windows/win32/procthread/process-creation-flags
const CREATE_NO_WINDOW: u32 = 0x0800_0000;

This is just the documentation for CREATE_NO_WINDOW from the linked Microsoft docs. Are you happy with this?

[extrawurst]

@icorbrey since this is a separate crate i can cut a release as soon as this is merged