Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Wrong hyperlink generated if filename contains both CJK characters and spaces #1230

Open
wzxu opened this issue Nov 13, 2024 · 1 comment
Labels
errors Something isn't working

Comments

@wzxu
Copy link

wzxu commented Nov 13, 2024

Consider the following 4 filenames:

  1. Test123.txt
  2. Test 123.txt
  3. 測試123.txt
  4. 測試 123.txt

All first 3 work normally, but only the 4th one, containing both CJK characters and spaces, generates broken filename in the link, depending on the terminal used.

  • Reference result by ls --hyperlink: %e6%b8%ac%e8%a9%a6%20123.txt
  • Result in iTerm2: %25E6%25B8%25AC%25E8%25A9%25A6%20123.txt
    • (3rd one is %E6%B8%AC%E8%A9%A6123.txt so here we have many redundant 25 appearing in the link)
  • Result in Ghostty/Alacritty/Zed: %E6%B8%AC%E8%A9%А6 123.txt
    • By the way the 2nd one is shown as just Test 123.txt rather than Test%20123.txt but it opens fine.

(Also won't work in WezTerm, or kitty, but they don't show the link content so I don't know what it looks like for them.)

  • The version of eza being used (eza --version)
    • v0.20.7 [+git]
  • The command-line arguments you are using
    • eza --hyperlink
  • Your shell and terminal
    • iTerm2, Ghostty ($TERM = xterm-256color for both)
  • Your operating system and hardware platform
    • macOS 14.6.1
@wzxu wzxu added the errors Something isn't working label Nov 13, 2024
@wzxu
Copy link
Author

wzxu commented Nov 18, 2024

Related: #843 #882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant