Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

계층 구조 변경하기 #36

Closed
2 tasks done
hyeok-kong opened this issue Jun 19, 2024 · 0 comments · Fixed by #37
Closed
2 tasks done

계층 구조 변경하기 #36

hyeok-kong opened this issue Jun 19, 2024 · 0 comments · Fixed by #37
Assignees
@hyeok-kong
Labels
refactoring

Comments

@hyeok-kong
Copy link
Collaborator

hyeok-kong commented Jun 19, 2024 •
edited
Loading

문제 사항

  • 현재 Service 내부에서 JwtReader를 직접 사용하는 클래스들이 존재합니다.
  • 계층 경계가 허물어져 통ㅎ바 테스트 작성에 어려움을 겪고 있습니다.

변경 사항

  • Controller 계층에서 JwtReader 사용하도록 변경
  • 변경에 따른 단위 테스트 재작성
@hyeok-kong hyeok-kong self-assigned this Jun 19, 2024
hyeok-kong added a commit that referenced this issue Jun 21, 2024
@hyeok-kong
Merge pull request #37 from f-lab-edu/refactoring/36
1b4386a 
[#36] JwtReader 서비스 계층에서 추출
@hyeok-kong hyeok-kong linked a pull request Jun 21, 2024 that will close this issue
[#36] JwtReader 서비스 계층에서 추출 #37
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyeok-kong hyeok-kong

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#36] JwtReader 서비스 계층에서 추출 f-lab-edu/music-everywhere
1 participant
@hyeok-kong