Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated CRDInfo.getVersion method #6609

Closed
manusa opened this issue Nov 15, 2024 · 0 comments · Fixed by #6615
Closed

Remove deprecated CRDInfo.getVersion method #6609

manusa opened this issue Nov 15, 2024 · 0 comments · Fixed by #6615
Labels
good first issue Easy hack; Good issue for new contributors help wanted low hanging fruit
Milestone
7.0.0

Comments

@manusa
Copy link
Member

manusa commented Nov 15, 2024

Description

Part of #6602

The following method, annotations and comments belong to a deprecated method that must be removed.

kubernetes-client/crd-generator/api/src/main/java/io/fabric8/crd/generator/CRDInfo.java

Lines 37 to 44 in 25ecf84

/**
* @deprecated Use {@link #getCrdSpecVersion()} instead
* @return the CRD spec version
*/
@Deprecated
public String getVersion() {
return getCrdSpecVersion();
}

@manusa manusa added help wanted low hanging fruit good first issue Easy hack; Good issue for new contributors labels Nov 15, 2024
@manusa manusa mentioned this issue Nov 15, 2024
Open
aswinayyolath added a commit to aswinayyolath/kubernetes-client that referenced this issue Nov 18, 2024
@aswinayyolath
Remove depricated getVersion() method from CRDInfo
af224a6 
Remove depricated getVersion() method from CRDInfo

Contributes to: fabric8io#6609

Signed-off-by: Aswin A <aswin6303@gmail.com>
@aswinayyolath aswinayyolath mentioned this issue Nov 18, 2024
Merged
11 tasks
@manusa manusa added this to the 7.0.0 milestone Nov 18, 2024 — with automated-tasks
manusa pushed a commit that referenced this issue Nov 18, 2024
@aswinayyolath
fix: removed deprecated CRDInfo.getVersion method
6fbc70f 
Remove depricated getVersion() method from CRDInfo

Contributes to: #6609

Signed-off-by: Aswin A <aswin6303@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Easy hack; Good issue for new contributors help wanted low hanging fruit
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Remove depricated getVersion() method from CRDInfo aswinayyolath/kubernetes-client
1 participant
@manusa