New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify code for sensor reading #212

Open

Yi-Shum opened this issue Mar 22, 2022 · 1 comment

Collaborator

Yi-Shum commented Mar 22, 2022

Hi @DelphineChiu,

We want to modify the code for sensor reading, including:

The member init_args in struct sensor_cfg should only be used in the function DeviceName_init().
So we want to add a private data member that will be used in other functions such as DeviceName_read().
Add the header files for each sensor.
Changed ADC amplification calculation from arg0 and arg1 to post_sensor_read_hook and post_sensor_read_args.

Do you have any suggestions for this?

Thanks,
Yi-Shum

DelphineChiu commented Mar 22, 2022

Meta and we plan to have main_v2 ready on 3/31.
Would you pls check main_v2 on #189 and provide the optimization based on main_v2?

Thanks,
Delphine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment