Skip to content

Commit

Permalink
Delete deprecated liquid player dependency
Browse files Browse the repository at this point in the history
Summary: The liquid player dependency has not been used since it was added in [2020](https://l.workplace.com/l.php?u=https%3A%2F%2Fwww.internalfb.com%2Fdiff%2FD22780550%3Fwhitespace%3DSHOW_ALL&h=AT14LQjuKK3Fc_XBpm9_DKN3Oqu_4aZEc98osMvhMqFHIAfHlY2yzM7mXcDtcd1Q1AcyKhox2DcBXw4T_CAVJjfR9YRlvNALcqw9RhDyOAQIXtgjsLYMNxXkX1u9OsPqOsTenjr8fMJDUKbBRBcT7Ee1qMIItoPpC0fd7g), and it is now causing all FBSDK diffs to fail tests due to the package manager no longer supporting it. We should remove this to re-enable progress on the FBSDK.

Reviewed By: jjiang10, KylinChang

Differential Revision: D63364134

fbshipit-source-id: 6b4ad2f9db7095436292c1d249f7698b17d416d1
  • Loading branch information
maxalbrightmeta authored and facebook-github-bot committed Sep 25, 2024
1 parent d56819b commit e024423
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions buildSrc/src/main/kotlin/Dependencies.kt
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ object Versions {
const val json = "20180130"
const val kotlin = "1.5.10"
const val leakcanaryAndroid = "2.9.1"
const val liquidcore = "0.6.2"
const val material = "1.0.0"
const val mockitoInline = "2.26.0"
const val mockitoKotlin = "2.2.11"
Expand Down Expand Up @@ -120,7 +119,6 @@ object Libs {
"com.squareup.leakcanary:leakcanary-android:${Versions.leakcanaryAndroid}"
const val leakcanary_object_watcher =
"com.squareup.leakcanary:leakcanary-object-watcher-android:${Versions.leakcanaryAndroid}"
const val liquidcore = "com.github.LiquidPlayer:LiquidCore:${Versions.liquidcore}"
const val mockito_inline = "org.mockito:mockito-inline:${Versions.mockitoInline}"
const val mockito_kotlin = "org.mockito.kotlin:mockito-kotlin:${Versions.mockitoKotlin}"
const val mockwebserver = "com.squareup.okhttp3:mockwebserver:${Versions.mockwebserver}"
Expand Down

0 comments on commit e024423

Please sign in to comment.