diff --git a/buckifier/check_buck_targets.sh b/buckifier/check_buck_targets.sh index 66c83c52f37..0f648c4fbf4 100755 --- a/buckifier/check_buck_targets.sh +++ b/buckifier/check_buck_targets.sh @@ -1,32 +1,44 @@ #!/usr/bin/env bash # Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. -# If clang_format_diff.py command is not specfied, we assume we are able to -# access directly without any path. -TGT_DIFF=`git diff TARGETS | head -n 1` +if [[ ! -f "BUCK" ]] +then + echo "BUCK file is missing!" + echo "Please do not remove / rename BUCK file in your commit(s)." + exit 1 +fi + +TGT_DIFF=`git diff BUCK | head -n 1` if [ ! -z "$TGT_DIFF" ] then - echo "TARGETS file has uncommitted changes. Skip this check." + echo "BUCK file has uncommitted changes. Skip this check." exit 0 fi -echo Backup original TARGETS file. +echo Backup original BUCK file. -cp TARGETS TARGETS.bkp +cp BUCK BUCK.bkp ${PYTHON:-python3} buckifier/buckify_rocksdb.py -TGT_DIFF=`git diff TARGETS | head -n 1` +if [[ ! -f "BUCK" ]] +then + echo "BUCK file went missing after running buckifier/buckify_rocksdb.py!" + echo "Please do not remove the BUCK file." + exit 1 +fi + +TGT_DIFF=`git diff BUCK | head -n 1` if [ -z "$TGT_DIFF" ] then - mv TARGETS.bkp TARGETS + mv BUCK.bkp BUCK exit 0 else - echo "Please run '${PYTHON:-python3} buckifier/buckify_rocksdb.py' to update TARGETS file." - echo "Do not manually update TARGETS file." + echo "Please run '${PYTHON:-python3} buckifier/buckify_rocksdb.py' to update BUCK file." + echo "Do not manually update BUCK file." ${PYTHON:-python3} --version - mv TARGETS.bkp TARGETS + mv BUCK.bkp BUCK exit 1 fi