Add support for TIME/TIME WITH TIME ZONE type

[wypb]

Presto has TIME type: https://prestodb.io/docs/current/language/types.html#time, But currently Velox doesn't support it. To support the TIME type in Velox, I will do the following:

• Implement TIME as a logical type and use bigint to represent it.
• Since only Presto currently supports the TIME type, I will put it in velox/functions/prestosql/types, just like the TimestampWithTimeZone type.
• I will implement common cast operations of the TIME type, such as cast(varchar as time), cast(timestamp as time), cast(time as varchar), just as implemented in TimeOperators
• Implementation of TIME type comparison operations, such as supporting CAST(STR AS TIME) < TIME '13:01:11.001'
• Function implementation related to TIME type, such as CheckSum, localtime, max,min, etc.

Thoughts? Cc: @mbasmanova @aditi-pandit @xumingming

[mbasmanova]

@wypb Thank you for helping with this.

Before deciding to implement TIME type as Presto-specific type, can you do a survey of database engines to find out which ones have a TIME type and whether that type is similar / different from Presto's.

Please, investigate how we would need to modify function signatures and fuzzers to accommodate the new type and include this in the design.

Function implementation related to TIME type, such as CheckSum, localtime, max,min, etc

Please, try to come up with as complete list of functions as possible.

comparison operations

Please, try to come up with as complete list as possible.

cast operations

Do we only need to support CAST to and from strings? If so, please, include a detailed description of the semantics.

Feel free to create and attach a Google doc with all these details to keep things organized.

Thanks.

[xumingming]

Seems a lot of work, I can help if you need some @wypb

[mbasmanova]

@xumingming Yes, I expect this to be a substantial effort. Thank you, @xumingming, for offering help.

[wypb]

@xumingming Thank you for offering help. After the design discussion is over, I will see how much specific work needs to be done, and then see if it should be divided.

[wypb]

HI @mbasmanova I wrote a simple design document. Can you help me take a look at it when you have time? https://docs.google.com/document/d/1RmMR7EtbGljNXeix51Ek_YebKAFC4doCOpkuQbV0758/edit

[wypb]

Do you think 1 day is sufficient to get a PR reviewed and approved? This estimate feels a bit low.

1 day should be relatively short, how about reserving 2 days?

Would you also add a tentative timeline for when each task will be delivered and provide an estimate of completion date for the whole project?

Ok

[wypb]

@mbasmanova I have submitted the code for task 1 #7212, please help to review this, thank you.

[aditi-pandit]

@mbasmanova : Yes, I can do a first round of reviews.

[mbasmanova]

@wypb Somehow I cannot find the PR for task 1. Would you share a link?

[wypb]

@mbasmanova The link to this PR can be found here