Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augmentation RandomCrop is not fully implemented #5384

Closed
pokecheater opened this issue Oct 24, 2024 · 2 comments
Closed

Augmentation RandomCrop is not fully implemented #5384

pokecheater opened this issue Oct 24, 2024 · 2 comments

Comments

@pokecheater
Copy link

Hi detectron2 team,

I noticed something strange when I used your augmentations.
The parameter crop_size had no effect at all so investigated.
Inside your codebase the parameter crop_size is defined and well documented but is not used at all.

image

This is also an issue in your latest version:
https://github.com/facebookresearch/detectron2/blob/main/detectron2/data/transforms/augmentation_impl.py

Greetings

Copy link

You've chosen to report an unexpected problem or bug. Unless you already know the root cause of it, please include details about it by filling the issue template.
The following information is missing: "Instructions To Reproduce the Issue and Full Logs"; "Your Environment";

@github-actions github-actions bot added the needs-more-info More info is needed to complete the issue label Oct 24, 2024
@pokecheater
Copy link
Author

My fault, should have read the code clearer the parameter is provided by locals()

@pokecheater pokecheater reopened this Oct 24, 2024
@github-actions github-actions bot removed the needs-more-info More info is needed to complete the issue label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant