Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling techniques on the render #102

Closed
miraclx opened this issue May 4, 2020 · 1 comment
Closed

Better error handling techniques on the render #102

miraclx opened this issue May 4, 2020 · 1 comment

Comments

@miraclx
Copy link
Contributor

miraclx commented May 4, 2020

The method of handling the render stderr data streams automatically infer critical errors. This might not always be true. As is with  #13#87#90#79#96. With the current method, terminalizer fails to render from little things such as GTK CSS theme warnings, warnings from failure to find the appmenu-gtk-modules as it did with mine.
Solution: Await the process to complete execution. If a non-zero return code is gotten, reject the render process.
Opening a PR to address this.

@miraclx
Copy link
Contributor Author

miraclx commented May 4, 2020

Fixed in #97.
Credits to @maricn (original issue: #96)
@faressoft, please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant