Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help text doesn't show up as Tooltip when hovering over stat on Character sheet #363

Open
hawkerm opened this issue Jan 31, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@hawkerm
Copy link

hawkerm commented Jan 31, 2022

🚩 Describe the bug

Understand that help shows up in full character sheet on not on character page to save space, but would expect to see it as a tooltip or something on hover/tap of the text to be able to get assistance.

🔢 Steps to reproduce

  1. Add help text to something on the character sheet
  2. Go to Characters page
  3. Hover mouse over that stat/block/bubble/etc...
  4. Nothing happens...

🟢 Expected behavior

Expect to get a tooltip which contains the help text as a player aid.

🔴 Actual behavior

Nothing happens.

💅 Screenshots

In Character Page:

image

In Character Sheet:

image

🖥 Desktop or Smartphone

  • OS: Windows
  • Browser: Edge
  • Device: PC
@hawkerm hawkerm added the bug Something isn't working label Jan 31, 2022
@hawkerm
Copy link
Author

hawkerm commented Jan 31, 2022

Not familiar with react or structure of project, but based on a quick poke... I imagine if the hideHelp is true, then a tooltip attribute could be added to the box here with the help text (as it's a general property vs. specific to the type of block):

https://github.com/fariapp/fari-app/blob/81fbe0e7363f7461bd1b6042bbe6159e9549b6cd/lib/routes/Character/components/CharacterDialog/components/BlockByType.tsx#L104

@RPDeshaies
Copy link
Collaborator

What do you mean by "character page" ? Do you mean the character cards ?

@hawkerm
Copy link
Author

hawkerm commented Feb 6, 2022

What do you mean by "character page" ? Do you mean the character cards ?

Yes, the character cards on the tab/page for characters in the main interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants