Typing error: Incompatible types in assignment (expression has type "ConfigDict", base class "SQLModel" defined the type as "SQLModelConfig")

[copdips]

First Check

• I added a very descriptive title here.
• I used the GitHub search to find a similar question and didn't find it.
• I searched the SQLModel documentation, with the integrated search.
• I already searched in Google "How to X in SQLModel" and didn't find any information.
• I already read and followed all the tutorial in the docs and didn't find an answer.
• I already checked if it is not related to SQLModel but to Pydantic.
• I already checked if it is not related to SQLModel but to SQLAlchemy.

Commit to Help

• I commit to help with one of those options 👆

Example Code

from pydantic import ConfigDict

class HeroCreate(SQLModel):
    name: str | None = None

    class Config:
        extra = "forbid"

class HeroUpdate(SQLModel):
    name: str | None = None
    model_config = ConfigDict(extra="forbid")

Description

Hello,

I need to add a config to prevent from extra fields when creating or updating Hero model.

Above example works well, but my VSCode raises linting errors

When using:

    class Config:
        extra = "forbid"

The linting error thrown by Pylance is:

"Config" overrides symbol of same name in class "SQLModel"
  "app.db.models.HeroCreate.Config" is incompatible with "sqlmodel.main.SQLModel.Config"
  Type "type[app.db.models.HeroCreate.Config]" cannot be assigned to type "type[sqlmodel.main.SQLModel.Config]"

When using the second format:

model_config: ConfigDict = ConfigDict(extra="forbid")

The linting error thrown by MyPy is:

Incompatible types in assignment (expression has type "ConfigDict", base class "SQLModel" defined the type as "SQLModelConfig")

Operating System

Linux

Operating System Details

No response

SQLModel Version

lastest: 0.0.16

Python Version

3.11.7

Additional Context

mypy 1.9.0
mypy-extensions 1.0.0

[SantiMNV]

I experience the same, any updates on this?

[joachimhuet]

It looks like SQLModelConfig still inherits the deprecated BaseConfig class. sqlmodel._compat.py.
If you change BaseConfig parent class with pydantic.ConfigDict does your warning remains ?

[copdips]

It seems that it uses already pydantic.ConfigDict:
https://github.com/tiangolo/sqlmodel/blob/6151f23e15703223128d641081b63d49a658d524/sqlmodel/_compat.py#L72-L73

[joachimhuet]

Oh yes you are right, it seems my editor point to the else condition by default. Probably mypy does not know where to look at neither.

I tried to reproduce and i get rid of the warning by doing that:

from sqlmodel._compat import SQLModelConfig

class BaseModel(SQLModel):
    model_config = cast(SQLModelConfig, {"extra": "forbid"})

But I'm not sure it is a good idea, just putting a # type: ignore would also safely work by passing a dict to model_config

class BaseModel(SQLModel):
    model_config = {"extra": "forbid"}  # type: ignore

[copdips]

if we were to accept # type: ignore, I would then add it directly to model_config = ConfigDict(extra="forbid")

[natehouk]

Any update on this?