-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
print-deps-only: Document we don't handle recursive deps (from files, e.g. -rrequirements.txt) #22
Comments
Note that |
Not sure how to handle constrains files here. On RPM level, we could wrap them in something like And that is also a valid solution of the |
It seems to me that to support requirements.txt properly, we'd basically need to reimplement pip's argument parsing :( |
The more I think about this the more I think tox-current-env should just document this and Parsing any possible pip command line arguments is not needed: those 2 options are explicitly documented in tox docs and I'd only consider more |
What about this (new part in bold):
Alternatively a new section in Other limitations and known bugs:
|
It may be a naive idea, but - if what tox does here is just pass this through to pip for parsing, can we not do the same? Just ask pip to parse it for us and tell us the result? Does pip have a 'print out the deps' mode? |
It's not a bad idea, but I don't think it does. And extending pip's API is quite hard. |
pyproject macros PR: https://src.fedoraproject.org/rpms/pyproject-rpm-macros/pull-request/36 |
Fedora report: https://bugzilla.redhat.com/show_bug.cgi?id=1808601
tox docs: https://tox.readthedocs.io/en/latest/example/basic.html#depending-on-requirements-txt-or-defining-constraints
When the dependencies are defined as:
We need to read the files (recursively) and output their content.
The code that handles this now is
tox-current-env/src/tox_current_env/hooks.py
Lines 161 to 172 in dc47ce3
The
*venv.get_resolved_dependencies()
call needs to be replaced with a custom function call. That function needs to callvenv.get_resolved_dependencies()
and handle "packages" that start with-r
/-c
specially.The text was updated successfully, but these errors were encountered: