From a648f49e1e9fb4e356859e3c0f3d8eae91f7425d Mon Sep 17 00:00:00 2001 From: Felix Angelov Date: Tue, 1 Aug 2023 21:46:56 -0500 Subject: [PATCH] chore(deps): more strict analysis options & upgrade to latest mocktail (#1024) --- README.md | 1 - analysis_options.yaml | 204 ++++++++++++++++++++ packages/mason/README.md | 1 - packages/mason/analysis_options.yaml | 2 +- packages/mason/pubspec.yaml | 5 +- packages/mason_api/README.md | 1 - packages/mason_api/analysis_options.yaml | 2 +- packages/mason_api/pubspec.yaml | 5 +- packages/mason_cli/README.md | 1 - packages/mason_cli/README.zh.md | 1 - packages/mason_cli/analysis_options.yaml | 2 +- packages/mason_cli/pubspec.yaml | 5 +- packages/mason_logger/README.md | 1 - packages/mason_logger/analysis_options.yaml | 2 +- packages/mason_logger/pubspec.yaml | 3 +- 15 files changed, 215 insertions(+), 21 deletions(-) diff --git a/README.md b/README.md index 48597f0aa..b3a64b59c 100644 --- a/README.md +++ b/README.md @@ -5,7 +5,6 @@

mason coverage -style: very good analysis License: MIT

diff --git a/analysis_options.yaml b/analysis_options.yaml index 4acf6d068..2a26aca7d 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -1,3 +1,207 @@ analyzer: exclude: - bricks/** + + language: + strict-casts: true + strict-inference: true + strict-raw-types: true + + errors: + close_sinks: ignore + missing_required_param: error + missing_return: error + record_literal_one_positional_no_trailing_comma: error + +linter: + rules: + - always_declare_return_types + - always_put_required_named_parameters_first + - always_use_package_imports + - annotate_overrides + - avoid_bool_literals_in_conditional_expressions + - avoid_catching_errors + - avoid_double_and_int_checks + - avoid_dynamic_calls + - avoid_empty_else + - avoid_equals_and_hash_code_on_mutable_classes + - avoid_escaping_inner_quotes + - avoid_field_initializers_in_const_classes + - avoid_final_parameters + - avoid_function_literals_in_foreach_calls + - avoid_init_to_null + - avoid_js_rounded_ints + - avoid_multiple_declarations_per_line + - avoid_null_checks_in_equality_operators + - avoid_positional_boolean_parameters + - avoid_print + - avoid_private_typedef_functions + - avoid_redundant_argument_values + - avoid_relative_lib_imports + - avoid_renaming_method_parameters + - avoid_return_types_on_setters + - avoid_returning_null_for_void + - avoid_returning_this + - avoid_setters_without_getters + - avoid_shadowing_type_parameters + - avoid_single_cascade_in_expression_statements + - avoid_slow_async_io + - avoid_type_to_string + - avoid_types_as_parameter_names + - avoid_unnecessary_containers + - avoid_unused_constructor_parameters + - avoid_void_async + - avoid_web_libraries_in_flutter + - await_only_futures + - camel_case_extensions + - camel_case_types + - cancel_subscriptions + - cascade_invocations + - cast_nullable_to_non_nullable + - collection_methods_unrelated_type + - combinators_ordering + - comment_references + - conditional_uri_does_not_exist + - constant_identifier_names + - control_flow_in_finally + - curly_braces_in_flow_control_structures + - dangling_library_doc_comments + - depend_on_referenced_packages + - deprecated_consistency + - directives_ordering + - empty_catches + - empty_constructor_bodies + - empty_statements + - eol_at_end_of_file + - exhaustive_cases + - file_names + - flutter_style_todos + - hash_and_equals + - implementation_imports + - implicit_call_tearoffs + - implicit_reopen + - invalid_case_patterns + - iterable_contains_unrelated_type + - join_return_with_assignment + - leading_newlines_in_multiline_strings + - library_annotations + - library_names + - library_prefixes + - library_private_types_in_public_api + - lines_longer_than_80_chars + - list_remove_unrelated_type + - literal_only_boolean_expressions + - missing_whitespace_between_adjacent_strings + - no_adjacent_strings_in_list + - no_default_cases + - no_duplicate_case_values + - no_leading_underscores_for_library_prefixes + - no_leading_underscores_for_local_identifiers + - no_logic_in_create_state + - no_runtimeType_toString + - non_constant_identifier_names + - noop_primitive_operations + - null_check_on_nullable_type_parameter + - null_closures + - omit_local_variable_types + - one_member_abstracts + - only_throw_errors + - overridden_fields + - package_api_docs + - package_names + - package_prefixed_library_names + - parameter_assignments + - prefer_adjacent_string_concatenation + - prefer_asserts_in_initializer_lists + - prefer_asserts_with_message + - prefer_collection_literals + - prefer_conditional_assignment + - prefer_const_constructors + - prefer_const_constructors_in_immutables + - prefer_const_declarations + - prefer_const_literals_to_create_immutables + - prefer_constructors_over_static_methods + - prefer_contains + - prefer_final_fields + - prefer_final_in_for_each + - prefer_final_locals + - prefer_for_elements_to_map_fromIterable + - prefer_function_declarations_over_variables + - prefer_generic_function_type_aliases + - prefer_if_elements_to_conditional_expressions + - prefer_if_null_operators + - prefer_initializing_formals + - prefer_inlined_adds + - prefer_int_literals + - prefer_interpolation_to_compose_strings + - prefer_is_empty + - prefer_is_not_empty + - prefer_is_not_operator + - prefer_iterable_whereType + - prefer_null_aware_method_calls + - prefer_null_aware_operators + - prefer_single_quotes + - prefer_spread_collections + - prefer_typing_uninitialized_variables + - prefer_void_to_null + - provide_deprecation_message + - public_member_api_docs + - recursive_getters + - require_trailing_commas + - secure_pubspec_urls + - sized_box_for_whitespace + - sized_box_shrink_expand + - slash_for_doc_comments + - sort_child_properties_last + - sort_constructors_first + - sort_pub_dependencies + - sort_unnamed_constructors_first + - test_types_in_equals + - throw_in_finally + - tighten_type_of_initializing_formals + - type_annotate_public_apis + - type_init_formals + - unawaited_futures + - unnecessary_await_in_return + - unnecessary_brace_in_string_interps + - unnecessary_breaks + - unnecessary_const + - unnecessary_constructor_name + - unnecessary_getters_setters + - unnecessary_lambdas + - unnecessary_late + - unnecessary_library_directive + - unnecessary_new + - unnecessary_null_aware_assignments + - unnecessary_null_checks + - unnecessary_null_in_if_null_operators + - unnecessary_nullable_for_final_variable_declarations + - unnecessary_overrides + - unnecessary_parenthesis + - unnecessary_raw_strings + - unnecessary_statements + - unnecessary_string_escapes + - unnecessary_string_interpolations + - unnecessary_this + - unnecessary_to_list_in_spreads + - unrelated_type_equality_checks + - use_build_context_synchronously + - use_colored_box + - use_enums + - use_full_hex_values_for_flutter_colors + - use_function_type_syntax_for_parameters + - use_if_null_to_convert_nulls_to_bools + - use_is_even_rather_than_modulo + - use_key_in_widget_constructors + - use_late_for_private_fields_and_variables + - use_named_constants + - use_raw_strings + - use_rethrow_when_possible + - use_setters_to_change_properties + - use_string_buffers + - use_string_in_part_of_directives + - use_super_parameters + - use_test_throws_matchers + - use_to_and_as_if_applicable + - valid_regexps + - void_checks diff --git a/packages/mason/README.md b/packages/mason/README.md index c95f3e5d6..def6ea8c2 100644 --- a/packages/mason/README.md +++ b/packages/mason/README.md @@ -6,7 +6,6 @@ Pub mason coverage -style: very good analysis License: MIT

diff --git a/packages/mason/analysis_options.yaml b/packages/mason/analysis_options.yaml index b61f16eb2..9eb715984 100644 --- a/packages/mason/analysis_options.yaml +++ b/packages/mason/analysis_options.yaml @@ -1,4 +1,4 @@ -include: package:very_good_analysis/analysis_options.4.0.0.yaml +include: ../../analysis_options.yaml analyzer: exclude: - "test/.test_coverage.dart" diff --git a/packages/mason/pubspec.yaml b/packages/mason/pubspec.yaml index ed46d5cdf..6ff1e11b9 100644 --- a/packages/mason/pubspec.yaml +++ b/packages/mason/pubspec.yaml @@ -8,7 +8,7 @@ issue_tracker: https://github.com/felangel/mason/issues documentation: https://github.com/felangel/mason/tree/master/packages/mason_cli#readme environment: - sdk: ">=2.19.0 <3.0.0" + sdk: ">=2.19.0 <4.0.0" dependencies: archive: ^3.1.11 @@ -31,6 +31,5 @@ dev_dependencies: build_verify: ^3.0.0 build_version: ^2.0.0 json_serializable: ^6.0.0 - mocktail: ^0.3.0 + mocktail: ^1.0.0 test: ^1.17.0 - very_good_analysis: ^4.0.0 diff --git a/packages/mason_api/README.md b/packages/mason_api/README.md index ee69a5593..73c165b52 100644 --- a/packages/mason_api/README.md +++ b/packages/mason_api/README.md @@ -3,7 +3,6 @@ [![build](https://github.com/felangel/mason/workflows/mason_api/badge.svg)](https://github.com/felangel/mason/actions) [![coverage](https://raw.githubusercontent.com/felangel/mason/master/packages/mason_api/coverage_badge.svg)](https://github.com/felangel/mason/actions) [![Pub](https://img.shields.io/pub/v/mason_api.svg)](https://pub.dev/packages/mason) -[![style: very good analysis](https://img.shields.io/badge/style-very_good_analysis-B22C89.svg)](https://pub.dev/packages/very_good_analysis) [![License: MIT](https://img.shields.io/badge/license-MIT-purple.svg)](https://opensource.org/licenses/MIT) A Dart API client used by [package:mason_cli](https://github.com/felangel/mason). diff --git a/packages/mason_api/analysis_options.yaml b/packages/mason_api/analysis_options.yaml index d972da045..88f2a678f 100644 --- a/packages/mason_api/analysis_options.yaml +++ b/packages/mason_api/analysis_options.yaml @@ -1,4 +1,4 @@ -include: package:very_good_analysis/analysis_options.4.0.0.yaml +include: ../../analysis_options.yaml analyzer: errors: todo: ignore diff --git a/packages/mason_api/pubspec.yaml b/packages/mason_api/pubspec.yaml index f144132e1..95899e87c 100644 --- a/packages/mason_api/pubspec.yaml +++ b/packages/mason_api/pubspec.yaml @@ -7,7 +7,7 @@ issue_tracker: https://github.com/felangel/mason/issues documentation: https://github.com/felangel/mason/tree/master/packages/mason_cli#readme environment: - sdk: ">=2.19.0 <3.0.0" + sdk: ">=2.19.0 <4.0.0" dependencies: cli_util: ^0.4.0 @@ -20,6 +20,5 @@ dependencies: dev_dependencies: build_runner: ^2.0.0 json_serializable: ^6.1.4 - mocktail: ^0.3.0 + mocktail: ^1.0.0 test: ^1.19.0 - very_good_analysis: ^4.0.0 diff --git a/packages/mason_cli/README.md b/packages/mason_cli/README.md index e488900b0..cc3a25372 100644 --- a/packages/mason_cli/README.md +++ b/packages/mason_cli/README.md @@ -6,7 +6,6 @@ Pub mason coverage -style: very good analysis License: MIT Powered by Mason

diff --git a/packages/mason_cli/README.zh.md b/packages/mason_cli/README.zh.md index 2713fa59c..a0ec23906 100644 --- a/packages/mason_cli/README.zh.md +++ b/packages/mason_cli/README.zh.md @@ -6,7 +6,6 @@ Pub mason coverage -style: very good analysis License: MIT Powered by Mason

diff --git a/packages/mason_cli/analysis_options.yaml b/packages/mason_cli/analysis_options.yaml index ad89d8a48..260a9852b 100644 --- a/packages/mason_cli/analysis_options.yaml +++ b/packages/mason_cli/analysis_options.yaml @@ -1,4 +1,4 @@ -include: package:very_good_analysis/analysis_options.4.0.0.yaml +include: ../../analysis_options.yaml analyzer: exclude: - "test/.test_coverage.dart" diff --git a/packages/mason_cli/pubspec.yaml b/packages/mason_cli/pubspec.yaml index 77ebe8428..ca3a6133e 100644 --- a/packages/mason_cli/pubspec.yaml +++ b/packages/mason_cli/pubspec.yaml @@ -8,7 +8,7 @@ issue_tracker: https://github.com/felangel/mason/issues documentation: https://docs.brickhub.dev environment: - sdk: ">=2.19.0 <3.0.0" + sdk: ">=2.19.0 <4.0.0" dependencies: args: ^2.1.0 @@ -25,9 +25,8 @@ dev_dependencies: build_verify: ^3.0.0 build_version: ^2.0.0 collection: ^1.15.0 - mocktail: ^0.3.0 + mocktail: ^1.0.0 test: ^1.17.0 - very_good_analysis: ^4.0.0 executables: mason: diff --git a/packages/mason_logger/README.md b/packages/mason_logger/README.md index b826e4b0c..4e65b6f8b 100644 --- a/packages/mason_logger/README.md +++ b/packages/mason_logger/README.md @@ -3,7 +3,6 @@ [![build](https://github.com/felangel/mason/workflows/mason_logger/badge.svg)](https://github.com/felangel/mason/actions) [![coverage](https://raw.githubusercontent.com/felangel/mason/master/packages/mason_logger/coverage_badge.svg)](https://github.com/felangel/mason/actions) [![Pub](https://img.shields.io/pub/v/mason_logger.svg)](https://pub.dev/packages/mason) -[![style: very good analysis](https://img.shields.io/badge/style-very_good_analysis-B22C89.svg)](https://pub.dev/packages/very_good_analysis) [![License: MIT](https://img.shields.io/badge/license-MIT-purple.svg)](https://opensource.org/licenses/MIT) A reusable logger used by the [Mason CLI](https://github.com/felangel/mason). diff --git a/packages/mason_logger/analysis_options.yaml b/packages/mason_logger/analysis_options.yaml index 86d4af14a..97b47c9f2 100644 --- a/packages/mason_logger/analysis_options.yaml +++ b/packages/mason_logger/analysis_options.yaml @@ -1,4 +1,4 @@ -include: package:very_good_analysis/analysis_options.5.0.0.yaml +include: ../../analysis_options.yaml analyzer: errors: todo: ignore \ No newline at end of file diff --git a/packages/mason_logger/pubspec.yaml b/packages/mason_logger/pubspec.yaml index dc6b6e591..990c902cf 100644 --- a/packages/mason_logger/pubspec.yaml +++ b/packages/mason_logger/pubspec.yaml @@ -12,6 +12,5 @@ environment: dev_dependencies: meta: ^1.7.0 - mocktail: ^0.3.0 + mocktail: ^1.0.0 test: ^1.19.0 - very_good_analysis: ^5.0.0