Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Misleading message when running make and having an invalid path brick globally #1203

Open
erickzanardo opened this issue Jan 3, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@erickzanardo
Copy link

Description

When having an invalid global installed brick, like for example a brick named foo that was installed from path, and such folder/path was deleted, when running mason make x we will get an error saying Could not find brick at path/foo, which can be confused since we are running mason make x.

Steps To Reproduce

  1. Install any brick globally from path
  2. Remove that path from the filesytem
  3. Try running mason make any_brick
  4. See error

Expected Behavior

Unsure what would be the best here, but I feel that it should either not give any error, and an error should occur only when trying to use the invalid brick, or maybe just silently removing the invalid brick from the mason lock?

@erickzanardo erickzanardo added the bug Something isn't working label Jan 3, 2024
@felangel
Copy link
Owner

felangel commented Jan 3, 2024

Thanks for reporting this! Curious to see how pub handles this situation. Either way I'll get a fix shortly, thanks! 🙏

@felangel felangel self-assigned this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants