Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONBUILD hook problems #13

Open
SerialVelocity opened this issue Mar 13, 2016 · 1 comment
Open

ONBUILD hook problems #13

SerialVelocity opened this issue Mar 13, 2016 · 1 comment
Assignees

Comments

@SerialVelocity
Copy link

Hey,

I've been trying to use this docker image (It's great btw!) but I'm encountering a rather annoying thing. I only want to inject an nginx.conf but that doesn't seem to be possible as I need to inject mime.types, fastcgi.conf, etc. Is it possible to either make it possible to disable the hook or just remove it entirely?

I think that users having to write one line so that their nginx configuration is added is perfectly fine.

Cheers,
SerialVelocity

@skozin
Copy link
Member

skozin commented Mar 15, 2016

Hi,

You're right, this may be quite confusing. What do you think about me splitting this image into two tags, e.g. base and onbuild (which is based on base and adds onbuild hooks), like in this image?

One thing to keep in mind is that, in this case, I'll have to alias latest to onbuild, not base, to maintain backwards compatibility, so you'll need to specify base as the tag to get rid of the hooks.

@skozin skozin self-assigned this Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants