Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent background color on dark mode [Chromium ONLY] #14110

Closed
saeedvaziry opened this issue Aug 31, 2024 · 6 comments
Closed

Inconsistent background color on dark mode [Chromium ONLY] #14110

saeedvaziry opened this issue Aug 31, 2024 · 6 comments
Labels

Comments

@saeedvaziry
Copy link

saeedvaziry commented Aug 31, 2024

Package

filament/filament

Package Version

v3.2.110

Laravel Version

11.11

Livewire Version

v3.5.6

PHP Version

PHP 8.2

Problem description

The background color is inconsistent in dark mode for all chromium-based browsers including Google Chrome and Brave.

image

A workaround to solve the problem is to give the same background color to .fi-main

Expected behavior

I think it should be same color across the page

Steps to reproduce

switch to dark mode and go to a page with less content so your browser doesn't start showing scroller.

For me, with a resolution of 2304 * 1296, it is possible to see the issue on the demo as well

Reproduction repository (issue will be closed if this is not valid)

https://github.com/filamentphp/demo

Relevant log output

No response

Donate 💰 to fund this issue

  • You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
  • 100% of the funding will be distributed between the Filament core team to run all aspects of the project.
  • Thank you in advance for helping us make maintenance sustainable!
Fund with Polar
Copy link

Hey @saeedvaziry! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2024
Copy link

Thank you for providing reproduction steps! Reopening the issue now.

@github-actions github-actions bot reopened this Aug 31, 2024
@andrewdwallo
Copy link
Contributor

Duplicate of #7759?

@saeedvaziry
Copy link
Author

@andrewdwallo yes but don't understand why closed

@andrewdwallo
Copy link
Contributor

I guess because it's browser specific and not an issue/bug with Filament? That is, unless it's something overlooked in Filament.

@danharrin
Copy link
Member

Issues are closed if there aren't actions we can take to fix Filament, it's like keeping an item on your todo list that is for someone else to solve. If you have any suggestions, please share or make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants