You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm gonna go ahead and ignore the template here because the issue is clear.
The assertTableActionDoesNotExist – and I'm assuming some other assertion helpers as well – are no longer asserting after this upgrade. This happens when the table action code is present.
As you can see, it can easily be missed especially when it is part of an existing test suite. I use this assertion for my most important "user has role to do ..." test cases and I assume many others do as well, so I believe it's quite important to at the very least introduce backwards compatibility, especailly given that it was a minor version upgrade.
I think a simple fix would be to force the implementation of the $checkActionUsing and $record parameters in v4, where a breaking change is permissable.
Expected behavior
N/A
Steps to reproduce
N/A
Reproduction repository (issue will be closed if this is not valid)
N/A
Relevant log output
N/A
Donate 💰 to fund this issue
You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
100% of the funding will be distributed between the Filament core team to run all aspects of the project.
Thank you in advance for helping us make maintenance sustainable!
The text was updated successfully, but these errors were encountered:
Hey @XbNz! We're sorry to hear that you've hit this issue. 💛
However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?
We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.
Also, it doesn't look like you've provided much information on how to replicate the issue. Please edit your original post with clear steps we need to take.
Package
filament/filament
Package Version
3.2.57
Laravel Version
11
Livewire Version
3
PHP Version
8.3
Problem description
I'm gonna go ahead and ignore the template here because the issue is clear.
The
assertTableActionDoesNotExist
– and I'm assuming some other assertion helpers as well – are no longer asserting after this upgrade. This happens when the table action code is present.Example:
3.2.56:
OK (1 test, 2 assertions)
3.2.57:
OK (1 test, 1 assertions)
As you can see, it can easily be missed especially when it is part of an existing test suite. I use this assertion for my most important "user has role to do ..." test cases and I assume many others do as well, so I believe it's quite important to at the very least introduce backwards compatibility, especailly given that it was a minor version upgrade.
I think a simple fix would be to force the implementation of the
$checkActionUsing
and$record
parameters in v4, where a breaking change is permissable.Expected behavior
N/A
Steps to reproduce
N/A
Reproduction repository (issue will be closed if this is not valid)
N/A
Relevant log output
Donate 💰 to fund this issue
The text was updated successfully, but these errors were encountered: