- *
SmartLock is enabled by default. + *
Credentials Manager is enabled by default. * - * @param enabled enables smartlock's credential selector and hint selector + * @param enableCredentialsManager enables credential manager */ @NonNull - public T setIsSmartLockEnabled(boolean enabled) { - return setIsSmartLockEnabled(enabled, enabled); - } - - /** - * Enables or disables the use of Smart Lock for Passwords credential selector and hint - * selector. - *
- *
Both selectors are enabled by default. - * - * @param enableCredentials enables credential selector before signup - * @param enableHints enable hint selector in respective signup screens - */ - @NonNull - public T setIsSmartLockEnabled(boolean enableCredentials, boolean enableHints) { - mEnableCredentials = enableCredentials; - mEnableHints = enableHints; + public T setIsCredentialsManagerEnabled(boolean enableCredentialsManager) { + mEnableCredentialsManager = enableCredentialsManager; return (T) this; } @@ -1547,8 +1529,7 @@ protected FlowParameters getFlowParams() { mLogo, mTosUrl, mPrivacyPolicyUrl, - mEnableCredentials, - mEnableHints, + mEnableCredentialsManager, mEnableAnonymousUpgrade, mAlwaysShowProviderChoice, mLockOrientation, diff --git a/auth/src/main/java/com/firebase/ui/auth/data/model/FlowParameters.java b/auth/src/main/java/com/firebase/ui/auth/data/model/FlowParameters.java index b43edda53..a47f77025 100644 --- a/auth/src/main/java/com/firebase/ui/auth/data/model/FlowParameters.java +++ b/auth/src/main/java/com/firebase/ui/auth/data/model/FlowParameters.java @@ -52,8 +52,7 @@ public FlowParameters createFromParcel(Parcel in) { int logoId = in.readInt(); String termsOfServiceUrl = in.readString(); String privacyPolicyUrl = in.readString(); - boolean enableCredentials = in.readInt() != 0; - boolean enableHints = in.readInt() != 0; + boolean enableCredentialsManager = in.readInt() != 0; boolean enableAnonymousUpgrade = in.readInt() != 0; boolean alwaysShowProviderChoice = in.readInt() != 0; boolean lockOrientation = in.readInt() != 0; @@ -69,8 +68,7 @@ public FlowParameters createFromParcel(Parcel in) { logoId, termsOfServiceUrl, privacyPolicyUrl, - enableCredentials, - enableHints, + enableCredentialsManager, enableAnonymousUpgrade, alwaysShowProviderChoice, lockOrientation, @@ -112,8 +110,7 @@ public FlowParameters[] newArray(int size) { @Nullable public final ActionCodeSettings passwordResetSettings; - public final boolean enableCredentials; - public final boolean enableHints; + public final boolean enableCredentialsManager; public final boolean enableAnonymousUpgrade; public final boolean alwaysShowProviderChoice; public final boolean lockOrientation; @@ -130,7 +127,6 @@ public FlowParameters( @Nullable String termsOfServiceUrl, @Nullable String privacyPolicyUrl, boolean enableCredentials, - boolean enableHints, boolean enableAnonymousUpgrade, boolean alwaysShowProviderChoice, boolean lockOrientation, @@ -145,8 +141,7 @@ public FlowParameters( this.logoId = logoId; this.termsOfServiceUrl = termsOfServiceUrl; this.privacyPolicyUrl = privacyPolicyUrl; - this.enableCredentials = enableCredentials; - this.enableHints = enableHints; + this.enableCredentialsManager = enableCredentials; this.enableAnonymousUpgrade = enableAnonymousUpgrade; this.alwaysShowProviderChoice = alwaysShowProviderChoice; this.lockOrientation = lockOrientation; @@ -171,8 +166,7 @@ public void writeToParcel(Parcel dest, int flags) { dest.writeInt(logoId); dest.writeString(termsOfServiceUrl); dest.writeString(privacyPolicyUrl); - dest.writeInt(enableCredentials ? 1 : 0); - dest.writeInt(enableHints ? 1 : 0); + dest.writeInt(enableCredentialsManager ? 1 : 0); dest.writeInt(enableAnonymousUpgrade ? 1 : 0); dest.writeInt(alwaysShowProviderChoice ? 1 : 0); dest.writeInt(lockOrientation ? 1 : 0); @@ -205,8 +199,7 @@ public boolean isAnonymousUpgradeEnabled() { public boolean isPlayServicesRequired() { // Play services only required for Google Sign In and the Credentials API return isProviderEnabled(GoogleAuthProvider.PROVIDER_ID) - || enableHints - || enableCredentials; + || enableCredentialsManager; } public boolean isProviderEnabled(@AuthUI.SupportedProvider String provider) { diff --git a/auth/src/main/java/com/firebase/ui/auth/ui/email/CheckEmailFragment.java b/auth/src/main/java/com/firebase/ui/auth/ui/email/CheckEmailFragment.java index 288857ce2..deaa747da 100644 --- a/auth/src/main/java/com/firebase/ui/auth/ui/email/CheckEmailFragment.java +++ b/auth/src/main/java/com/firebase/ui/auth/ui/email/CheckEmailFragment.java @@ -90,9 +90,10 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat ImeHelper.setImeOnDoneListener(mEmailEditText, this); - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && getFlowParams().enableHints) { - mEmailEditText.setImportantForAutofill(View.IMPORTANT_FOR_AUTOFILL_NO); - } + // TODO(hackathon): figure out if we want to have autofill or not. +// if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && getFlowParams().enableHints) { +// mEmailEditText.setImportantForAutofill(View.IMPORTANT_FOR_AUTOFILL_NO); +// } mNextButton.setOnClickListener(this); @@ -170,7 +171,7 @@ protected void onFailure(@NonNull Exception e) { if (!TextUtils.isEmpty(email)) { mEmailEditText.setText(email); validateAndProceed(); - } else if (getFlowParams().enableHints) { + } else if (getFlowParams().enableCredentialsManager) { // TODO(hackathon): Fetch credential // mHandler.fetchCredential(); } diff --git a/auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailFragment.java b/auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailFragment.java index 3ad13674c..ca6014215 100644 --- a/auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailFragment.java +++ b/auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailFragment.java @@ -171,7 +171,7 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat // Only show the name field if required nameInput.setVisibility(requireName ? View.VISIBLE : View.GONE); - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && getFlowParams().enableCredentials) { + if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && getFlowParams().enableCredentialsManager) { mEmailEditText.setImportantForAutofill(View.IMPORTANT_FOR_AUTOFILL_NO); } diff --git a/auth/src/main/java/com/firebase/ui/auth/ui/phone/CheckPhoneNumberFragment.java b/auth/src/main/java/com/firebase/ui/auth/ui/phone/CheckPhoneNumberFragment.java index 77eec7899..230fef1dc 100644 --- a/auth/src/main/java/com/firebase/ui/auth/ui/phone/CheckPhoneNumberFragment.java +++ b/auth/src/main/java/com/firebase/ui/auth/ui/phone/CheckPhoneNumberFragment.java @@ -89,9 +89,10 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat mSmsTermsText.setText(getString(R.string.fui_sms_terms_of_service, getString(R.string.fui_verify_phone_number))); - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && getFlowParams().enableHints) { - mPhoneEditText.setImportantForAutofill(View.IMPORTANT_FOR_AUTOFILL_NO); - } + // TODO(hackathon): figure out if we want to have autofill or not. +// if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && getFlowParams().enableHints) { +// mPhoneEditText.setImportantForAutofill(View.IMPORTANT_FOR_AUTOFILL_NO); +// } requireActivity().setTitle(getString(R.string.fui_verify_phone_number_title)); ImeHelper.setImeOnDoneListener(mPhoneEditText, () -> onNext()); @@ -234,7 +235,7 @@ private void setDefaultCountryForSpinner() { "", countryIso, String.valueOf(PhoneNumberUtils.getCountryCode(countryIso)))); - } else if (getFlowParams().enableHints) { + } else if (getFlowParams().enableCredentialsManager) { // TODO(hackathon): fetch user credential // mCheckPhoneHandler.fetchCredential(); }