Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [storage-resize-images] Extension crops the image with default settings. #2106

Open
mehmet2006 opened this issue May 31, 2024 · 2 comments · May be fixed by #2115
Open

🐛 [storage-resize-images] Extension crops the image with default settings. #2106

mehmet2006 opened this issue May 31, 2024 · 2 comments · May be fixed by #2115
Labels
type: bug Something isn't working

Comments

@mehmet2006
Copy link

[READ] Step 1: Are you in the right place?

Issues filed here should be about bugs for a specific extension in this repository.
If you have a general question, need help debugging, or fall into some
other category use one of these other channels:

  • For general technical questions, post a question on StackOverflow
    with the firebase tag.
  • For general Firebase discussion, use the firebase-talk
    google group.
  • To file a bug against the Firebase Extensions platform, or for an issue affecting multiple extensions, please reach out to
    Firebase support directly.

[REQUIRED] Step 2: Describe your configuration

  • Extension name: storage-resize-images (storage-resize-images, firestore-send-email, etc)
  • Extension version: 0.2.5
  • Configuration values (redact info where appropriate):
    • _
    • _

[REQUIRED] Step 3: Describe the problem

In the documentation it says, it will keep the aspect ratio when resizing images.
But currently it doesn't. It crops the image

Steps to reproduce:

1- Install the extension
2- Add 300x300, 756x756, 900x900 image resolutions
3- What the installation finished
4- Upload an image
5- Check the results

Expected result

Images should have been resized with the same aspect ratio and crop should have happen

Actual result

Images lost their aspect ratio and and it is cropped

@mehmet2006 mehmet2006 added the type: bug Something isn't working label May 31, 2024
@gregives
Copy link

@mehmet2006 did you find a workaround for this? I'm also experiencing the same problem!

@gregives
Copy link

I've submitted a pull request to fix this issue. If anyone needs a workaround in the meantime, change this setting in the configuration of the extension.

Sharp constructor options for resizing images

{ "fit": "inside" }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants