Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Missing MultiFactor property in UserRecord #379

Open
cperez87 opened this issue Feb 19, 2024 · 5 comments
Open

[FR] Missing MultiFactor property in UserRecord #379

cperez87 opened this issue Feb 19, 2024 · 5 comments
Assignees
Labels
api: auth type: feature request A new feature API is requested

Comments

@cperez87
Copy link

cperez87 commented Feb 19, 2024

Hi,
The MultiFactor property is missing in the .NET (and Java) implementation of UserRecord.
Other implementations like Go, Python, and Node already have it.

While we wait for it to be added, is there any recommendation to get the raw response returned by the accounts:lookup call?

Thanks

@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@cperez87
Copy link
Author

In the meantime, I ended up creating a custom HttpClientFactory to add a custom DelegatingHandler with a Channel. And subscribe to it to capture the Response content.
Any other temporary suggestion is welcome.

@lahirumaramba lahirumaramba changed the title Missing MultiFactor property in UserRecord [FR] Missing MultiFactor property in UserRecord Mar 11, 2024
@lahirumaramba lahirumaramba added type: feature request A new feature API is requested and removed needs-triage labels Mar 11, 2024
@Somebodybro
Copy link

Somebodybro commented Jun 11, 2024

Hey! I made a fork for this here and started working on this so i'll make a pr when that is done.

There are some new things I need to do, like adding a list property to userRecordArgs, but that should be fine.

There should not be any other problem in doing this except adding the fields and making them serialize/deserialize correctly.

This is my first time contributing to the firebase .net sdk repo, so if you see anything dubious in the fork a bit later, when I've gotten it to works and such, do say something here, so that I can fix it before piling on a lot of work on a misguided version!

@Somebodybro
Copy link

I created a pullrequest for this!

#409

If there is any deeper discussion to be had about it, that cannot be handled within the pr comments, I think that can be had here?

@Somebodybro
Copy link

@lahirumaramba My pull request has been floating around for a while.
If there is something wrong with it, i'm more than happy to keep working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: auth type: feature request A new feature API is requested
Projects
None yet
Development

No branches or pull requests

5 participants