Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fcm): Exported MaxMessages constant #389

Closed
wants to merge 1 commit into from
Closed

fix(fcm): Exported MaxMessages constant #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions messaging/messaging_batch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ import (
"firebase.google.com/go/v4/internal"
)

const maxMessages = 500
// MaxMessages is the maximum number of messages that can be included in the message array.
const MaxMessages = 500

const multipartBoundary = "__END_OF_PART__"

// MulticastMessage represents a message that can be sent to multiple devices via Firebase Cloud
Expand All @@ -52,8 +54,8 @@ func (mm *MulticastMessage) toMessages() ([]*Message, error) {
if len(mm.Tokens) == 0 {
return nil, errors.New("tokens must not be nil or empty")
}
if len(mm.Tokens) > maxMessages {
return nil, fmt.Errorf("tokens must not contain more than %d elements", maxMessages)
if len(mm.Tokens) > MaxMessages {
return nil, fmt.Errorf("tokens must not contain more than %d elements", MaxMessages)
}

var messages []*Message
Expand Down Expand Up @@ -166,8 +168,8 @@ func (c *fcmClient) sendBatch(
return nil, errors.New("messages must not be nil or empty")
}

if len(messages) > maxMessages {
return nil, fmt.Errorf("messages must not contain more than %d elements", maxMessages)
if len(messages) > MaxMessages {
return nil, fmt.Errorf("messages must not contain more than %d elements", MaxMessages)
}

request, err := c.newBatchRequest(messages, dryRun)
Expand Down