Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse from HTTP errors and prefer that as the cannonical error code when it is provided #1633

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: parse from HTTP errors and prefer that as the cannonical error code when it is provided #1633

wants to merge 2 commits into from

Conversation

MarkDuckworth
Copy link

@MarkDuckworth MarkDuckworth commented Jul 15, 2024 •
edited
Loading

@MarkDuckworth MarkDuckworth requested review from a team as code owners July 15, 2024 15:02
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 15, 2024
@MarkDuckworth
Copy link
Author

API reference https://cloud.google.com/apis/design/errors#error_mapping

This was referenced Jul 15, 2024
Open
Open
@leahecole
Copy link
Contributor

@sofisl is it worth also adding a test in the test-application for this? Maybe a modification of the existing testEchoError test?

@jellynoone
Copy link

Is there any ETA on this? As described in firebase/firebase-admin-node#2587 (comment), under certain situations the fact the error codes mapping is lossy could be exploited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
3 participants
@MarkDuckworth @leahecole @jellynoone