Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Add generated client files to fcm #1344

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

maceonthompson
Copy link

[Draft]
The result of moving autogenerated fcm client code using GAPIC into the messaging directory. Subsequent PRs will be made into this branch as development continues (namely, migrating to the generated client over messaging-api-request-internal.ts

This is part of an ongoing internship project/experiment in the feasibility of using autogenerated clients, which will hopefully make supporting multiple apis across multiple languages easier in the long term.

@maceonthompson maceonthompson changed the title Add generated client files to fcm [Draft] Add generated client files to fcm Jun 24, 2021
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. We need to figure out a way to resolve the lint errors. Plus some suggestions on the directory structure.

src/messaging/src/index.ts Outdated Show resolved Hide resolved
src/messaging/src/index.ts Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
src/messaging/src/v1/fcm_service_client.ts Outdated Show resolved Hide resolved
@hiranya911
Copy link
Contributor

I see that you've nested generated within the existing src directory, which is not quite what I had in mind. I was suggesting that we put generated at the root of the repo (same level as src). However, this is likely to complicate our build quite a bit (TypeScript will have to pull sources from 2 directories, and combine the compiled output into one).

So lets use the structure you currently have for now. Later we can discuss other approaches for organizing these files in our repo.

…ly run (#1353)

* Update Gulpfile to copy files required for generated code to run.

* Fix introduced typo on 104

* Remove redundant glob from `copyJson()` task
This PR serves as a proof of concept to show that GAPIC generated clients can be integrated with Firebase Admin APIs. It also shows that this integration for pre-existing APIs requires a relatively substantial amount of work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants